Update k8s-infra-prow groups, add prow OWNERS files#1636
Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom Feb 10, 2021
Merged
Update k8s-infra-prow groups, add prow OWNERS files#1636k8s-ci-robot merged 1 commit intokubernetes:mainfrom
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
area/access
Contributor
Author
|
/cc @BenTheElder @chaodaiG |
spiffxp
force-pushed
the
update-prow-groups
branch
from
7ee8e69 to
3f89793
Compare
Specifically - k8s-infra-prow-oncall - reconcile membership with test-infra-oncall - reconcile membership with sig-testing-leads - k8s-infra-prow-viewers - replace scalability-oncall members with group - prow OWNERS files - reviewers: approvers + test-infra-oncall + releng reviewers - cluster approvers: sig-testing-leads + ameukam - cluster resource approvers: cluster approvers + test-infra-oncall - bash approvers: wg-k8s-infra-org-admins There is prow-related stuff littered in many of the infra/gcp scripts, so to get things to a point where k8s-infra-prow-oncall members can approve and run prow-related script changes is going to require more of a refactor than is relevant to the scope of this PR
spiffxp
force-pushed
the
update-prow-groups
branch
from
3f89793 to
31cf984
Compare
k8s-ci-robot
added
size/L
chaodaiG
approved these changes
Feb 10, 2021
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaodaiG, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Member
|
thank you! |
Contributor
Author
|
/kind cleanup |
k8s-ci-robot
added
kind/cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specifically
Approvers were determined by whether an approver could cause changes to be deployed
There is prow-related stuff littered in many of the infra/gcp scripts,
so to get things to a point where k8s-infra-prow-oncall members can
approve and run prow-related script changes is going to require more
of a refactor than is relevant to the scope of this PR