Skip to content

releng: create new gcp project k8s-infra-staging-releng-test to test images build#1592

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
cpanato:k-release-GH-1850
Jan 29, 2021
Merged

releng: create new gcp project k8s-infra-staging-releng-test to test images build#1592
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
cpanato:k-release-GH-1850

Conversation

@cpanato
Copy link
Copy Markdown
Member

@cpanato cpanato commented Jan 29, 2021

Part of kubernetes/release#1850

Need to set up a GCP project to hold the images that we build for testing the process and don't overwrite others.

This is to improve our confidence when building the images we need for the whole project

/assign @justaugustus @dims @spiffxp
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. wg/k8s-infra labels Jan 29, 2021
@cpanato cpanato changed the title releng: create new gcp project k8s-infra-staging-k8s-releng-test to test images build releng: create new gcp project k8s-infra-staging-releng-test to test images build Jan 29, 2021
Copy link
Copy Markdown
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
Copy link
Copy Markdown
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato -- A few changes to address...

Please also drop all of the changes in k8s.gcr.io/images/k8s-staging-releng-test/**.

There shouldn't be any need to promote images from this project; it's only going to be for proving the images can get built in presubmit.

/hold (you can lift this once my review is addressed)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2021
@cpanato cpanato requested a review from justaugustus January 29, 2021 12:06
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 29, 2021
@dims
Copy link
Copy Markdown
Member

dims commented Jan 29, 2021

waiting for @justaugustus

@justaugustus
Copy link
Copy Markdown
Member

@cpanato -- The group description still needs to be adjusted, as suggested in #1592 (comment).

@justaugustus
Copy link
Copy Markdown
Member

/lgtm
/approve

@justaugustus
Copy link
Copy Markdown
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 29, 2021
@dims
Copy link
Copy Markdown
Member

dims commented Jan 29, 2021

/approve
/lgtm

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, dims, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 75f9a8c into kubernetes:master Jan 29, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Jan 29, 2021
@cpanato cpanato deleted the k-release-GH-1850 branch January 29, 2021 14:40
@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jan 29, 2021

@dims, how long it takes for the account to be provisioned?

@dims
Copy link
Copy Markdown
Member

dims commented Jan 29, 2021

@justaugustus error running script!

davanum@cloudshell:~/k8s.io$ infra/gcp/ensure-staging-storage.sh releng-test
Configuring staging: releng-test
  Ensuring project exists: k8s-staging-releng-test
  Create in progress for [https://cloudresourcemanager.googleapis.com/v1/projects/k8s-staging-releng-test].
  Waiting for [operations/cp.7198884732138064981] to finish...
  ..done.
  billingAccountName: billingAccounts/018801-93540E-22A20E
  billingEnabled: true
  name: projects/k8s-staging-releng-test/billingInfo
  projectId: k8s-staging-releng-test
  Empowering k8s-infra-staging-releng-test@kubernetes.io as project viewers
  ERROR: Policy modification failed. For a binding with condition, run "gcloud alpha iam policies lint-condition" to identify issues in condition.
  ERROR: (gcloud.projects.add-iam-policy-binding) INVALID_ARGUMENT: Group k8s-infra-staging-releng-test@kubernetes.io does not exist.

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jan 29, 2021

@dims who or where the k8s-infra-staging-releng-test@kubernetes.io is created?

per item 4 https://github.com/kubernetes/k8s.io/tree/master/k8s.gcr.io#creating-staging-repos is you :)

@dims
Copy link
Copy Markdown
Member

dims commented Jan 29, 2021

@cpanato doing that manually now, looks like the groups.yaml sync script failed or did not run

@cpanato
Copy link
Copy Markdown
Member Author

cpanato commented Jan 29, 2021

thanks @dims

@dims
Copy link
Copy Markdown
Member

dims commented Jan 29, 2021

This is ready now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants