Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sweep for dead links #140

Closed
justaugustus opened this issue Sep 29, 2018 · 7 comments · Fixed by #200
Closed

Sweep for dead links #140

justaugustus opened this issue Sep 29, 2018 · 7 comments · Fixed by #200
Assignees
@nikhita
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.

Comments

@justaugustus
Copy link
Member

In reviewing kubernetes/community#2408, I noticed that http://cherrypick.k8s.io/#/queue times out. We should sweep the nginx config for dead links and remove them.

/sig contributor-experience
/help
@k8s-ci-robot
Copy link
Contributor

@justaugustus:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

In reviewing kubernetes/community#2408, I noticed that http://cherrypick.k8s.io/#/queue times out. We should sweep the nginx config for dead links and remove them.

/sig contributor-experience
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Sep 29, 2018
@justaugustus justaugustus mentioned this issue Sep 29, 2018
Merged
@ixdy
Copy link
Member

ixdy commented Oct 1, 2018

Yeah, I believe cherrypick.k8s.io was part of the old mungegithub service, which has since been turned down.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 31, 2018
@nikhita
Copy link
Member

nikhita commented Jan 23, 2019

/remove-lifecycle stale
/assign

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 23, 2019
@ezzoueidi
Copy link
Contributor

I see that the PR #2408 has been merged. If it doesn't close this issue. I would like to work on it. Thanks :)

@nikhita
Copy link
Member

nikhita commented Feb 22, 2019 •
edited
Loading

I see that the PR #2408 has been merged. If it doesn't close this issue. I would like to work on it. Thanks :)

That PR just checks for the cherry-pick link, so please feel free to work on this!

Checking if all the links mentioned here https://github.com/kubernetes/k8s.io/tree/master/k8s.io work + fixing them/mentioning invalid ones in the issue here should be good enough. :)

@ezzoueidi
Copy link
Contributor

There is an invalid URLs which are: https://go.k8s.io and https://go.kubernetes.io
The missing one are: https://blog.kubernetes.io and https://kubernetes.io
And there is only one URL which is https://kubernetes.submit-queue.k8s.io, the correct one is https://submit-queue.kubernetes.io

@ezzoueidi ezzoueidi mentioned this issue Feb 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikhita nikhita

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix and delete invalid links
6 participants
@justaugustus @ezzoueidi @ixdy @nikhita @k8s-ci-robot @fejta-bot