Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCLB] Migrate existing health check settings #863

Merged
merged 2 commits into from
Jun 15, 2017
Merged

[GCLB] Migrate existing health check settings #863

merged 2 commits into from
Jun 15, 2017

Conversation

nicksardo
Copy link
Contributor

Fixes #842

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2017
@nicksardo nicksardo requested a review from bowei June 14, 2017 23:16
@k8s-reviewable
Copy link

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 46.572% when pulling f65b35f on nicksardo:gce-legacy-healthcheck into 245e6b0 on kubernetes:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 46.572% when pulling 06204c6 on nicksardo:gce-legacy-healthcheck into 245e6b0 on kubernetes:master.

@nicksardo
Copy link
Contributor Author

After several runs of testing, it's ready for review. @bowei

@nicksardo nicksardo mentioned this pull request Jun 15, 2017
Merged
MrHohn
MrHohn approved these changes Jun 15, 2017
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looks pretty straight forward!

@MrHohn
Copy link
Member

MrHohn commented Jun 15, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2017
@nicksardo nicksardo merged commit 4ae523e into kubernetes:master Jun 15, 2017
@nicksardo nicksardo deleted the gce-legacy-healthcheck branch June 15, 2017 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@bowei bowei Awaiting requested review from bowei

Assignees

@MrHohn MrHohn

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nicksardo @k8s-reviewable @coveralls @MrHohn @k8s-ci-robot