-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement support for GCE health check with HTTP Host Header in GLBC #393
Implement support for GCE health check with HTTP Host Header in GLBC #393
Conversation
Coverage increased (+0.07%) to 46.199% when pulling c4dbc87ceb82e3bd4c05e54813e830c168aed93a on itamaro:glbc-healthcheck-with-host-header into edb9b00 on kubernetes:master. |
I'll look at this after 0.9.2 goes out. The flagset fix was small and harmless enough to include. Thanks. Edit: See issue for comments |
@itamaro Could you rebase this and fix it up? We were considering to use the node-level health check implemented in K8s 1.7.0, but have decided against that path. Thanks! |
c4dbc87
to
b6c1693
Compare
Coverage increased (+0.02%) to 46.678% when pulling b6c16934a0b3da43be6193396fc746e6dfd87c7d on itamaro:glbc-healthcheck-with-host-header into c6b5335 on kubernetes:master. |
pushed an attempt. it seems much has changed since my initial attempt, so I'm not sure this is correct (and can't test it at the moment). |
Thanks. Needs this line to use the correct host: https://github.com/kubernetes/ingress/blob/ca5f402322097b7fc079effaa2597eadae65734d/controllers/gce/backends/backends.go#L463 as you did in the previous commit. I can make a new PR if you're too busy for this - didn't want to steal your work. |
b6c1693
to
488dd07
Compare
something like the update I've pushed? feel free to modify it, you should have write permissions :-) |
/lgtm Tested this and it worked fine. Thanks @itamaro! |
Fixes issue #388 (for me, at least :-) )