Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.19.0 #3014

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Release 0.19.0 #3014

merged 1 commit into from
Aug 30, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 30, 2018

Test image: quay.io/aledbf/nginx-ingress-controller:0.414

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2018
@aledbf
Copy link
Member Author

aledbf commented Aug 30, 2018

/hold

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 30, 2018
@aledbf
Copy link
Member Author

aledbf commented Aug 30, 2018

@blakebarnett ping

@blakebarnett
Copy link

awesome, thank you I'll try to test it tomorrow.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@edc6e93). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3014   +/-   ##
=========================================
  Coverage          ?   47.48%           
=========================================
  Files             ?       77           
  Lines             ?     5644           
  Branches          ?        0           
=========================================
  Hits              ?     2680           
  Misses            ?     2611           
  Partials          ?      353

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edc6e93...fda1419. Read the comment docs.

@antoineco
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, antoineco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit 05025d6 into kubernetes:master Aug 30, 2018
@aledbf aledbf deleted the 0.19 branch August 31, 2018 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants