Automate building developer environment #2417
Conversation
k8s-ci-robot
added
cncf-cla: yes
I am going to simplify the manifests and enable RBAC by default so this is not going to be an issue. |
docs/development.md
Outdated
| $ make dev-env | ||
| ``` | ||
|
|
||
| **IMPORTANT**: This will uninstall minikube from your machine and reinstall version 0.25.0. |
There was a problem hiding this comment.
Do we absolutely need to enforce this? RBAC can happily coexist with the AlwaysAllow authorization mode and be enabled for auditing only. I believe most developers want to keep their local environment up to date.
There was a problem hiding this comment.
Maybe that (quite unknown) feature would be less destructive? kubernetes/minikube#2371
There was a problem hiding this comment.
@antoineco profiles do not work with --vm-driver=kvm2 :)
There was a problem hiding this comment.
It's only an issue because of the e2e-tests failing. This won't be an issue once @aledbf makes the updates mentioned above. I can remove this part of the script and then deploy with RBAC instead.
Codecov Report
@@ Coverage Diff @@
## master #2417 +/- ##
==========================================
+ Coverage 40.91% 41.05% +0.13%
==========================================
Files 74 74
Lines 5252 5252
==========================================
+ Hits 2149 2156 +7
+ Misses 2809 2803 -6
+ Partials 294 293 -1
Continue to review full report at Codecov.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
@zrdaley please squash the commits |
|
/approve |
|
/lgtm |
k8s-ci-robot
added
approved
|
@zrdaley thanks! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, antoineco, zrdaley The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Setting up the development environment is quite time consuming and somewhat confusing. This script creates a quick command that will allow MacOS developers to set up their quickly by automating the following tasks:
1. Stop and uninstall minikube2. Install minikube version 0.25.03. Start minikube
4. Dep ensure to get
vendor/dependencies5. Build the local ingress controller container
6. Install kubectl
7. Deploy the controller & update the image
Which issue this PR fixes: N/A
Special notes for your reviewer:
Minikube versions > 0.25.0 enable RBAC on the cluster. This will cause the e2e-tests to fail. Therefore a suitable development environment requires version 0.25.0 or less.