Skip to content

Conversation

@Gacko
Copy link
Member

@Gacko Gacko commented Oct 8, 2025

/triage accepted
/kind cleanup
/priority backlog

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 8, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gacko

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@netlify
Copy link

netlify bot commented Oct 8, 2025

Deploy Preview for kubernetes-ingress-nginx canceled.

Name Link
🔨 Latest commit c5c0f86
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-ingress-nginx/deploys/68e5ef8feff02c0008d2dc88

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 8, 2025
@Gacko Gacko added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2025
@k8s-ci-robot k8s-ci-robot merged commit 70e01ff into kubernetes:main Oct 8, 2025
46 checks passed
@Gacko Gacko deleted the vqhvo branch October 8, 2025 06:19
@cpanato
Copy link
Member

cpanato commented Oct 9, 2025

Flagging this. You cannot open a PR and merge yourself without any review; this is not correct. I have seen this happening for quite some time, and this is not correct. There is a process in the K8s community, and that should be followed.

If it were a one-person project, I would understand that, but there are a couple of people in this project

cc @kubernetes/steering-committee for visibility

@BenTheElder
Copy link
Member

Flagging this. You cannot open a PR and merge yourself without any review; this is not correct. I have seen this happening for quite some time, and this is not correct. There is a process in the K8s community, and that should be followed.

Speaking personally, the steering committee can only formally respond with a majority vote. I am not signing this as steering. That holds for any comment which does not clearly state it is on behalf of steering.

We don't actually have any governance that requires this as far as I know, it's up to the subprojects. I think there are many cases for expedited merging and small CVE patches seem like one of those cases?

Disclosure: I do this myself in kind from time to time because the project is small with few maintainers and when we have decided for example to cut a release while other maintainers are busy I need to merge the checked-in files that document the release along with the git tag etc.

We have other cases for clicking merge like "CI/infra config is broken and this is the config repo".

There are other projects that do this very often, I think it depends on understanding amongst the maintainers and care should be taken for things like the CLA when clicking merge.

I don't know if that understanding exists for this project.

@Gacko
Copy link
Member Author

Gacko commented Oct 10, 2025

See my DM on Slack. I can still make it public, if you want. That can be decided in the DM.

@tao12345666333
Copy link
Member

Essentially, due to our understaffing and the current dependency updates being a routine process, relying on the regular approach could cause this task to take over two days to complete.
We agree with Marco's current approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants