-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Go: Bump to v1.25.2. #14019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go: Bump to v1.25.2. #14019
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
|
Flagging this. You cannot open a PR and merge yourself without any review; this is not correct. I have seen this happening for quite some time, and this is not correct. There is a process in the K8s community, and that should be followed. If it were a one-person project, I would understand that, but there are a couple of people in this project cc @kubernetes/steering-committee for visibility |
Speaking personally, the steering committee can only formally respond with a majority vote. I am not signing this as steering. That holds for any comment which does not clearly state it is on behalf of steering. We don't actually have any governance that requires this as far as I know, it's up to the subprojects. I think there are many cases for expedited merging and small CVE patches seem like one of those cases? Disclosure: I do this myself in kind from time to time because the project is small with few maintainers and when we have decided for example to cut a release while other maintainers are busy I need to merge the checked-in files that document the release along with the git tag etc. We have other cases for clicking merge like "CI/infra config is broken and this is the config repo". There are other projects that do this very often, I think it depends on understanding amongst the maintainers and care should be taken for things like the CLA when clicking merge. I don't know if that understanding exists for this project. |
|
See my DM on Slack. I can still make it public, if you want. That can be decided in the DM. |
|
Essentially, due to our understaffing and the current dependency updates being a routine process, relying on the regular approach could cause this task to take over two days to complete. |
/triage accepted
/kind cleanup
/priority backlog