-
Notifications
You must be signed in to change notification settings - Fork 8.5k
Tests: Add ssl-session-* config values tests.
#13742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Add ssl-session-* config values tests.
#13742
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
|
Hi @marcel2012. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Gacko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/triage accepted
/kind cleanup
/priority backlog
/lgtm
ssl-session-* config values tests.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gacko, marcel2012 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-1.13 |
|
/cherry-pick release-1.12 |
|
@Gacko: new pull request created: #13745 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Gacko: new pull request created: #13746 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@Gacko: new pull request could not be created: failed to create pull request against kubernetes/ingress-nginx#release-1.13 from head k8s-infra-cherrypick-robot:cherry-pick-13742-to-release-1.13: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-13742-to-release-1.13."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
This PR adds ssl-session-* config values tests. This will prevent error like this from occurring again.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: