Skip to content

Controller: Fix nil pointer in path validation. #13679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025
Merged

Controller: Fix nil pointer in path validation. #13679

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fa3394
fix: add possible nil dereference in inspector error msg
wooffie Jul 28, 2025
fd5803e
Apply suggestions from code review
Gacko Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/ingress/inspector/inspector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,11 @@ func ValidatePathType(ing *networking.Ingress) error {
}
if path.PathType == nil || *path.PathType != implSpecific {
if isValid := validPathType.MatchString(path.Path); !isValid {
err = errors.Join(err, fmt.Errorf("path %s cannot be used with pathType %s", path.Path, string(*path.PathType)))
pathTypeStr := "nil"
if path.PathType != nil {
pathTypeStr = string(*path.PathType)
}
err = errors.Join(err, fmt.Errorf("path %s cannot be used with pathType %s", path.Path, pathTypeStr))
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions internal/ingress/inspector/inspector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ var (
PathType: &prefix,
Path: "/lala/xp\ntest",
},
{
Path: "notvalidpathname-panics",
},
},
},
},
Expand Down Expand Up @@ -174,6 +177,7 @@ func TestValidatePathType(t *testing.T) {
aErr("xpto/lala", "Exact"),
aErr("/foo/bar/[a-z]{3}", "Prefix"),
aErr("/lala/xp\ntest", "Prefix"),
aErr("notvalidpathname-panics", "nil"),
),
},
}
Expand Down