-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix tcp/udp services example explanation #10220
docs: fix tcp/udp services example explanation #10220
Conversation
✅ Deploy Preview for kubernetes-ingress-nginx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @jdockerty! |
Hi @jdockerty. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
yup, e2e test does not lie, you are right :) nice catch |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jdockerty, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Assuming my understanding of how I've used this is correct, this explanation is actually backwards.
The mention of
<namespace/service name>:<service port>
is not how the data is shown when presented in the TCP/UDPConfigMap
, it is instead<service port>: <namespace/service name>:...
, similar to the example given in the same document (comments are mine).Perhaps this could be clarified in an even better way too. Happy to take suggestions/be wrong about this too if I'm misunderstood it.
What this PR does / why we need it:
Clarification of the documentation to the example provided.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: