Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator #91

Merged
merged 4 commits into from
Dec 28, 2017
Merged

Translator #91

merged 4 commits into from
Dec 28, 2017

Conversation

bowei
Copy link
Member

@bowei bowei commented Dec 23, 2017

Move translator into its own package
Clean up cross dependencies; this is a pure refactor

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 23, 2017
@bowei bowei requested a review from nikhiljindal December 23, 2017 08:59
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 23, 2017
@bowei bowei requested a review from nicksardo December 23, 2017 08:59
@k8s-ci-robot
Copy link
Contributor

@bowei: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-ingress-gce-e2e a2fec81 link /test pull-ingress-gce-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bowei bowei requested a review from freehan December 27, 2017 21:51
@bowei bowei merged commit c8a8d90 into kubernetes:master Dec 28, 2017
@bowei bowei deleted the translator branch December 28, 2017 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants