add timeout for polling NEG health status for pod readiness #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bowei
reviewed
Aug 27, 2019
pkg/neg/readiness/reflector.go
Outdated
| // 3. syncPod patches the neg readiness condition to be false | ||
| reason = negNotReadyReason | ||
| message = fmt.Sprintf("Waiting for pod to become healthy in at least one of the NEG(s): %v", negs) | ||
| // check if the pod has been waiting for the endpoint to show up as Healthy in NEG for too long |
There was a problem hiding this comment.
can we make things return early for the code to be easier to reason about
if len(negs) == 0 {
expectedCondition.Status = ...
expectedCondition... = ...
return r.ensurePodNegCondition(pod, expectedCondition)
}
and so forth (get rid of the else's)
bowei
reviewed
Aug 27, 2019
pkg/neg/readiness/reflector_test.go
Outdated
| { | ||
| desc: "timeout waiting for endpoint to become healthy in NEGs", | ||
| mutateState: func() { | ||
| //pod := generatePodWithTimestamp(testNamespace, podName, true, false, false, now.Truncate(unreadyTimeout)) |
| Type: shared.NegReadinessGate, | ||
| Reason: negReadyTimedOutReason, | ||
| Status: v1.ConditionTrue, | ||
| Message: fmt.Sprintf("Timeout waiting for pod to become healthy in at least one of the NEG(s): %v. Marking condition %q to True.", []string{"neg1", "neg2"}, shared.NegReadinessGate), |
There was a problem hiding this comment.
this is pretty fragile, I guess it's ok since the code is so close the test
pkg/neg/readiness/reflector.go
Outdated
| negReadyReason = "LoadBalancerNegReady" | ||
| negNotReadyReason = "LoadBalancerNegNotReady" | ||
| maxRetries = 15 | ||
| negReadyReason = "LoadBalancerNegReady" |
There was a problem hiding this comment.
might want to document each of these
k8s-ci-robot
added
size/L
|
Addressed the comments. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 10, 2019
Cherrypick #834 into release 1.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent pod to be stuck in unready state due to misconfiguration