add more neg tests #829
Merged
add more neg tests #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
needs-rebase
freehan
force-pushed
the
neg-test
branch
4 times, most recently
from
65b6f94 to
6bd623a
Compare
bowei
reviewed
Aug 19, 2019
cmd/e2e-test/neg_test.go
Outdated
| port80 := intstr.FromInt(80) | ||
|
|
||
| ctx := context.Background() | ||
| numForwardingRules := 1 |
cmd/e2e-test/neg_test.go
Outdated
| } | ||
|
|
||
| scaleAndValidate(2) | ||
|
|
There was a problem hiding this comment.
why this sequence? is there something specific that is being tested here (document in a comment)
pkg/e2e/helpers.go
Outdated
|
|
||
| // CheckDistinctResponseHost issue GET call to the vip for 100 times, parse the reponses and calculate the number of distinct backends. | ||
| func CheckDistinctResponseHost(vip string, expectDistinctHosts int, tolerateTransientError bool) error { | ||
| errs := []error{} |
pkg/e2e/helpers.go
Outdated
| // CheckDistinctResponseHost issue GET call to the vip for 100 times, parse the reponses and calculate the number of distinct backends. | ||
| func CheckDistinctResponseHost(vip string, expectDistinctHosts int, tolerateTransientError bool) error { | ||
| errs := []error{} | ||
| repeat := 100 |
pkg/e2e/helpers.go
Outdated
| } | ||
| wantedReplicas := *deployment.Spec.Replicas | ||
|
|
||
| if deployment.Status.Replicas != wantedReplicas { |
There was a problem hiding this comment.
you could do to avoid mismatches
for _, f := range []struct{
v *int
name string
want int
}{
{&deployment.Status.Replicas, "replicas", wantedReplicas},
{&deployment.Status.ReadyReplicas, "ready replicas", wantedReplicas},
{&deployment.Status.AvailabledReplicas, "available replicas", wantedReplicas},
{&deployment.Status.UpdatedReplicas, "updated replicas", wantedReplicas},
...
}{
if *f.v != f.want {
return fmt.Errorf("deployment %s/%s has %d %s, want %d", deployment.Namespace, deployment.Name, *f.v, f.name, f.want)
}
}
|
Fixed. Ready for another round. |
bowei
reviewed
Aug 20, 2019
pkg/e2e/fixtures.go
Outdated
| @@ -189,3 +236,16 @@ func DeleteGCPAddress(s *Sandbox, name string) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func GetNegStatus(s *Sandbox, name string) (annotations.NegStatus, bool, error) { | |||
There was a problem hiding this comment.
seems weird to return both bool and error?
pkg/e2e/helpers.go
Outdated
| } | ||
|
|
||
| if deployment.Status.UnavailableReplicas != 0 { | ||
| return fmt.Errorf("deployment %s/%s has %v unavailable replicas, want 0", deployment.Namespace, deployment.Name, deployment.Status.UnavailableReplicas) |
There was a problem hiding this comment.
seems like this would just be?
{&deployment.Status.UnavailableReplicas, "unavailable replicas", 0},
pkg/e2e/helpers.go
Outdated
|
|
||
| // CheckNegs checks if the network endpoints in the NEGs is in expected state | ||
| func CheckNegs(negs map[meta.Key]*fuzz.NetworkEndpoints, expectHealthy bool, expectCount int) error { | ||
| count := 0 |
There was a problem hiding this comment.
var (
count int
errs []error
negNames []string
)
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrate part of the test from OSS k8s