-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add beta regional resources to composite #798
Add beta regional resources to composite #798
Conversation
Hi @spencerhance. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@spencerhance Is this ready for review? Not sure since its not explicitly assigned. |
@rramkumar1 whoops my bad. /assign @rramkumar1 😄 |
/ok-to-test |
7d424f0
to
7e0f24c
Compare
/retest |
@bowei this should be good to go now that k8s-cloud-provider has been updated |
some of the indentation of the code templates have strange indentation. not going to block on that though. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, spencerhance The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
This will be necessary to use L7-ILB Beta