Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beta regional resources to composite #798

Merged

Conversation

spencerhance
Copy link
Contributor

@spencerhance spencerhance commented Jul 19, 2019

This will be necessary to use L7-ILB Beta

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 19, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2019
@k8s-ci-robot k8s-ci-robot requested review from freehan and MrHohn July 19, 2019 04:24
@rramkumar1
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 2, 2019
@rramkumar1
Copy link
Contributor

@spencerhance Is this ready for review? Not sure since its not explicitly assigned.

@spencerhance
Copy link
Contributor Author

@rramkumar1 whoops my bad. /assign @rramkumar1 😄

@bowei
Copy link
Member

bowei commented Aug 2, 2019

/ok-to-test

pkg/composite/gen.go Outdated Show resolved Hide resolved
pkg/composite/gen.go Outdated Show resolved Hide resolved
pkg/composite/gen.go Outdated Show resolved Hide resolved
pkg/composite/gen/main.go Outdated Show resolved Hide resolved
pkg/composite/gen/main.go Outdated Show resolved Hide resolved
pkg/composite/gen/main.go Outdated Show resolved Hide resolved
@spencerhance spencerhance force-pushed the composite-beta-regional branch from 7d424f0 to 7e0f24c Compare August 3, 2019 00:05
@spencerhance
Copy link
Contributor Author

/retest

@spencerhance
Copy link
Contributor Author

@bowei this should be good to go now that k8s-cloud-provider has been updated

@bowei
Copy link
Member

bowei commented Aug 7, 2019

some of the indentation of the code templates have strange indentation. not going to block on that though.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 7, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bowei
Copy link
Member

bowei commented Aug 7, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2019
@k8s-ci-robot k8s-ci-robot merged commit 2fe3b2f into kubernetes:master Aug 7, 2019
@spencerhance spencerhance deleted the composite-beta-regional branch June 29, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants