Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More composite updates for integration #790

Merged
merged 1 commit into from
Jul 12, 2019
Merged

More composite updates for integration #790

merged 1 commit into from
Jul 12, 2019

Conversation

spencerhance
Copy link
Contributor

/assign bowei

blocking #788

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @spencerhance. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 2, 2019
@k8s-ci-robot k8s-ci-robot requested review from bowei and freehan July 2, 2019 20:58
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 2, 2019
bowei
bowei reviewed Jul 2, 2019
View reviewed changes
pkg/composite/utils.go Outdated Show resolved Hide resolved
bowei
bowei reviewed Jul 2, 2019
View reviewed changes
pkg/composite/composite.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 2, 2019
@spencerhance spencerhance mentioned this pull request Jul 2, 2019
Merged
@spencerhance spencerhance force-pushed the more-composite-updates-for-integration branch from 2bd08b2 to 6380df2 Compare July 2, 2019 22:36
@freehan
Copy link
Contributor

freehan commented Jul 2, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 2, 2019
bowei
bowei reviewed Jul 3, 2019
View reviewed changes
pkg/composite/utils.go Outdated Show resolved Hide resolved
pkg/composite/utils.go Outdated
func ParseScope(selfLink string) (meta.KeyType, error) {
resourceID, err := cloud.ParseResourceURL(selfLink)
if err != nil {
var empty meta.KeyType
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not necessary

return meta.KeyType{}, fmt.Errorf(...)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That actually won't compile since KeyType is a string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced it with meta.KeyType("") and that works

pkg/composite/utils_test.go Outdated Show resolved Hide resolved
pkg/composite/utils.go Outdated Show resolved Hide resolved
@spencerhance spencerhance force-pushed the more-composite-updates-for-integration branch 2 times, most recently from e97e337 to ed3dc19 Compare July 9, 2019 01:13
@bowei
Copy link
Member

bowei commented Jul 9, 2019

/approve

ping when done and I will lgtm

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@spencerhance spencerhance force-pushed the more-composite-updates-for-integration branch from ed3dc19 to 0e8e4e0 Compare July 9, 2019 20:01
@spencerhance
Copy link
Contributor Author

@bowei should be good to go now

@spencerhance
Copy link
Contributor Author

@bowei friendly ping

@bowei
Copy link
Member

bowei commented Jul 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bowei, spencerhance

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f93941a into kubernetes:master Jul 12, 2019
@spencerhance spencerhance deleted the more-composite-updates-for-integration branch July 12, 2019 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei bowei left review comments

@freehan freehan Awaiting requested review from freehan

Assignees

@bowei bowei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spencerhance @k8s-ci-robot @freehan @bowei