Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding docker configuration file for the 404-server-with-metrics and … #745

Merged
merged 1 commit into from
May 2, 2019
Merged

Adding docker configuration file for the 404-server-with-metrics and … #745

merged 1 commit into from
May 2, 2019

Conversation

vbannai
Copy link
Contributor

@vbannai vbannai commented May 2, 2019

…also changing the Makefile to push by default to the gcr.io staging repository.

@vbannai
Adding docker configuration file for the 404-server-with-metrics and …
98bd13e 
…also changing the Makefile to push by default to the gcr.io staging repository.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @vbannai. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 2, 2019
@k8s-ci-robot k8s-ci-robot requested review from MrHohn and thockin May 2, 2019 15:49
@MrHohn
Copy link
Member

MrHohn commented May 2, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 2, 2019
MrHohn
MrHohn approved these changes May 2, 2019
View reviewed changes
Copy link
Member

@MrHohn MrHohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Dockerfile.404-server-with-metrics
@@ -0,0 +1,20 @@
# Copyright 2015 The Kubernetes Authors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2019

MrHohn
MrHohn reviewed May 2, 2019
View reviewed changes
Makefile
# Registry to push to.
REGISTRY ?= gcr.io/google_containers
# Push to the staging registry.
REGISTRY ?= gcr.io/k8s-image-staging
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use staging-k8s.gcr.io? Ref https://github.com/kubernetes/dns/blob/master/Makefile.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am all for consistency. There is no difference between gcr.io/k8s-image-staging and staging-k8s.gcr.io as staging-k8s.gcr.io points to gcr.io/k8s-image-staging.
I can change it to staging-k8s.gcr.io if you insist. Let me know.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah don't have strong opinion --- I don't recall the reason for using alias either.

@MrHohn
Copy link
Member

MrHohn commented May 2, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrHohn, vbannai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6f9394c into kubernetes:master May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn MrHohn approved these changes

@thockin thockin Awaiting requested review from thockin

Assignees

@MrHohn MrHohn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vbannai @k8s-ci-robot @MrHohn