Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transaction Syncer #532

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Conversation

freehan
Copy link
Contributor

@freehan freehan commented Nov 2, 2018

This PR introduces transaction NEG syncer. This syncer is non blocking. It will not wait for batches of NEG operation to finish before trigger more NEG operations.

PR prerequistes:
#528
#509
#499

TODOs:

  • add a flag to switch between batch syncer and transaction syncer
  • add more unit test
  • make this more readable

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2018
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2018
@freehan freehan force-pushed the transaction-syncer2 branch from 7dd9af1 to 59c33fb Compare November 9, 2018 02:17
@freehan freehan force-pushed the transaction-syncer2 branch 3 times, most recently from 877578a to 72cf77a Compare November 19, 2018 19:21
@freehan freehan force-pushed the transaction-syncer2 branch from 72cf77a to a768cde Compare November 19, 2018 19:59
@rramkumar1
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 20, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: freehan, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ddcbea3 into kubernetes:master Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants