Restructure syncer package #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
freehan
force-pushed
the
unblocking-syncer
branch
2 times, most recently
from
719a195 to
d35d3a3
Compare
agau4779
reviewed
Oct 3, 2018
pkg/neg/syncers/utils.go
Outdated
|
|
||
| // encodeEndpoint encodes ip and instance into a single string | ||
| func encodeEndpoint(ip, instance, port string) string { | ||
| return fmt.Sprintf("%s||%s||%s", ip, instance, port) |
There was a problem hiding this comment.
Nit - since || is used as the separator elsewhere, keep as const at the top
agau4779
reviewed
Oct 3, 2018
pkg/neg/syncers/utils.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func negSyncerName(key NegSyncerKey) string { |
There was a problem hiding this comment.
this could be a func (k NegSyncerKey) String() string method
freehan
force-pushed
the
unblocking-syncer
branch
2 times, most recently
from
f9c7c17 to
5df00df
Compare
|
fixed the comments |
freehan
force-pushed
the
unblocking-syncer
branch
from
5df00df to
e35f1d5
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bowei, freehan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structural changes only. No functional change:
cc: @agau4779