Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gce provider in vendor #277

Merged
merged 3 commits into from
May 21, 2018

Conversation

MrHohn
Copy link
Member

@MrHohn MrHohn commented May 19, 2018

Update kubernetes/kubernetes to kubernetes/kubernetes@77a08ee.

Also updated the signature for SetSslCertificateForTargetHttpsProxy() (kubernetes/kubernetes@f9d1f7e).

/assign @nicksardo

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 19, 2018
@nicksardo
Copy link
Contributor

nicksardo commented May 19, 2018

Awesome. When was the last time you updated your dep binary? The PR is adding back lots of markdown and some shell files. I was under impression those would be pruned out during ensure...

@MrHohn
Copy link
Member Author

MrHohn commented May 19, 2018

The PR is adding back lots of markdown and some shell files.

Good catch, I never update the dep binary :) Will fix.

@MrHohn MrHohn force-pushed the revendor-gce-provider branch from 4458aab to a7d8190 Compare May 19, 2018 19:42
@MrHohn
Copy link
Member Author

MrHohn commented May 19, 2018

Seem cleaner now :)

@nicksardo
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2018
@nicksardo nicksardo merged commit 1b546ee into kubernetes:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants