Refactor translator.ToURLMap to not re-fetch backend services #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/cc @MrHohn |
rramkumar1
force-pushed
the
translator-refactor-1
branch
3 times, most recently
from
8b9fc52 to
d99b42f
Compare
MrHohn
reviewed
Apr 11, 2018
pkg/utils/namer.go
Outdated
| @@ -84,6 +84,9 @@ const ( | |||
|
|
|||
| // schemaVersionV1 is the version 1 naming scheme for NEG | |||
| schemaVersionV1 = "1" | |||
|
|
|||
| // linkPrefix is the prefix for the link of GCE resources. | |||
| linkPrefix = "https://www.googleapis.com/compute/v1/projects" | |||
There was a problem hiding this comment.
Should we have different prefixes for alpha/beta/ga?
rramkumar1
force-pushed
the
translator-refactor-1
branch
3 times, most recently
from
5de9f60 to
3fa5161
Compare
nicksardo
reviewed
Apr 11, 2018
pkg/utils/utils.go
Outdated
|
|
||
| // BackendRelativeResourcePath returns a relative path of the link for a | ||
| // BackendService given its name. | ||
| func BackendRelativeResourcePath(name string) string { |
There was a problem hiding this comment.
Let's use BackendService to not get confused with BackendService.Backend
nicksardo
reviewed
Apr 11, 2018
pkg/utils/utils.go
Outdated
| // BackendComparableGroupPath trims project and compute version from the SelfLink | ||
| // for a global BackendService. | ||
| // /global/backendServices/[BACKEND_SERVICE_NAME] | ||
| func BackendComparableGroupPath(url string) string { |
There was a problem hiding this comment.
Group was referring to InstanceGroup, which isn't applicable for the BackendService.
Maybe "BackendServiceComparablePath"
nicksardo
reviewed
Apr 11, 2018
pkg/utils/utils.go
Outdated
| // /global/backendServices/[BACKEND_SERVICE_NAME] | ||
| func BackendComparableGroupPath(url string) string { | ||
| path_parts := strings.Split(url, "/global/") | ||
| return fmt.Sprintf("/global/%s", path_parts[1]) |
There was a problem hiding this comment.
We should handle the error case of len(url) != 2... Guessing we return empty.
rramkumar1
force-pushed
the
translator-refactor-1
branch
from
3fa5161 to
ca7c1c9
Compare
|
Adding tests now. |
rramkumar1
force-pushed
the
translator-refactor-1
branch
4 times, most recently
from
501fbb9 to
8b15093
Compare
nicksardo
reviewed
Apr 12, 2018
| if a.Service != b.Service { | ||
| // Trim down the url's for a.Service and b.Service to a comparable structure | ||
| // We do this because we update the UrlMap with relative links (not full) to backends. | ||
| if utils.BackendServiceComparablePath(a.Service) != utils.BackendServiceComparablePath(b.Service) { |
There was a problem hiding this comment.
There are two more lines with Service equality checks. 775 and 805.
nicksardo
reviewed
Apr 12, 2018
pkg/utils/utils.go
Outdated
|
|
||
| // BackendServiceComparablePath trims project and compute version from the SelfLink | ||
| // for a global BackendService. | ||
| // /global/backendServices/[BACKEND_SERVICE_NAME] |
rramkumar1
force-pushed
the
translator-refactor-1
branch
from
8b15093 to
a3c7bc7
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/assign @nicksardo @MrHohn
Will update tests once approach is LGTM'd.