Add some documentation on post-release TODO's #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
nikhiljindal
reviewed
Apr 4, 2018
docs/dev/post-release-TODOS.md
Outdated
| ## Update Manifest | ||
|
|
||
| The glbc.manifest in the main kubernetes repository needs to be updated | ||
| to use the new image. The file is located at kubernetes/cluster/gce/manifests/glbc.manifest. |
There was a problem hiding this comment.
docs/dev/post-release-TODOS.md
Outdated
| The glbc.manifest in the main kubernetes repository needs to be updated | ||
| to use the new image. The file is located at kubernetes/cluster/gce/manifests/glbc.manifest. | ||
| Make sure to not only update the image for the container but also update the | ||
| name in the top-level metadata field as well as version field under metadata.labels. |
There was a problem hiding this comment.
Will linking to an example PR help?
docs/dev/post-release-TODOS.md
Outdated
|
|
||
| ### ci-ingress-gce-upgrade-e2e | ||
|
|
||
| Find a file called config.json under test-infra/jobs/config.json. In this file, |
There was a problem hiding this comment.
Same comment as above, add a link to that file and an example PR
docs/dev/post-release-TODOS.md
Outdated
|
|
||
| ### ci-ingress-gce-downgrade-e2e | ||
|
|
||
| Find a file called nodes_util.go under kubernetes/test/e2e/framework. |
There was a problem hiding this comment.
same comment as above :)
docs/dev/post-release-TODOS.md
Outdated
| @@ -0,0 +1,29 @@ | |||
| # Post-Release TODO's | |||
There was a problem hiding this comment.
optional nit: TODO's have a specific meaning in code and I dont think thats what we mean here.
Some other naming suggestions: release-guide or release-steps.
Feel free to ignore the comment.
There was a problem hiding this comment.
Good call, I didn't really like TODO either.
k8s-ci-robot
added
size/M
rramkumar1
force-pushed
the
master
branch
2 times, most recently
from
701a8c0 to
6c9d5c8
Compare
|
/assign @nicksardo |
nikhiljindal
reviewed
Apr 4, 2018
docs/dev/post-release-steps.md
Outdated
|
|
||
| ### ci-ingress-gce-upgrade-e2e | ||
|
|
||
| In this [file](https://github.com/kubernetes/test-infra/blob/master/jobs/config.json), |
There was a problem hiding this comment.
nit: its generally a good idea to print the name of the file, so In [config.json] instead of In this [file]
|
Thanks for the fixes @rramkumar1 |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly for keeping track of things we need to do when a new release is cut.
/assign @nikhiljindal