Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated ingress api version #1848

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated ingress api version #1848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LIMITATIONS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ It takes ~1m to spin up a loadbalancer (this includes acquiring the public IP),

Assume one creates the following simple Ingress:
```yaml
apiVersion: extensions/v1beta1
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: test-ingress
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add the annotation for this to be valid yaml. In v1 either the annotation or the ingress class name field is required, but GKE doesn't use the class name.

Expand Down
2 changes: 1 addition & 1 deletion docs/faq/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Either shutdown the controller satisfying the Ingress, or use the
`ingress.class` annotation:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this annotation was deprecated in v1 in favor of a field https://docs.konghq.com/kubernetes-ingress-controller/latest/concepts/ingress-versions/#ingress-class

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this public doc https://cloud.google.com/kubernetes-engine/docs/concepts/ingress#deprecated_annotation, it describes we should still use ingress.class.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kundan2707 we can also link to the GKE public docs here: https://cloud.google.com/kubernetes-engine/docs/how-to/custom-ingress-controller


```yaml
apiVersion: extensions/v1beta1
apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: test
Expand Down
2 changes: 1 addition & 1 deletion docs/troubleshooting/troubleshooting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ $ kubectl exec test-701078429-s5kca -- curl --cacert /var/run/secrets/kubernetes
"/apis/certificates.k8s.io",
"/apis/certificates.k8s.io/v1alpha1",
"/apis/extensions",
"/apis/extensions/v1beta1",
"/apis/networking.k8s.io/v1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to fix this output you have to update more apis that are no longer on that version

"/apis/policy",
"/apis/policy/v1alpha1",
"/apis/rbac.authorization.k8s.io",
Expand Down