Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of proposals directory corrected. #8

Closed
wants to merge 1 commit into from
Closed

Location of proposals directory corrected. #8

wants to merge 1 commit into from

Conversation

CsatariGergely
Copy link

No description provided.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@philips
Copy link
Contributor

philips commented Jun 25, 2016

LGTM, why isn't this merged? cc @erictune

@philips
Copy link
Contributor

philips commented Jun 25, 2016

Gah, it is because of the CLA. @CsatariGergely you have to sign a CLA to do this change.

@idvoretskyi
Copy link
Member

@CsatariGergely, yes, we are still waiting for CLA from @CsatariGergely.

@CsatariGergely
Copy link
Author

@idvoretskyi, @philips: I'm discussing the CLA issue with @bgrant0607, @sarahnovotny, @aronchick and @monadic in mail.

@philips
Copy link
Contributor

philips commented Jul 18, 2016

@CsatariGergely what is the conclusion of the CLA issue?

@philips
Copy link
Contributor

philips commented Jul 18, 2016

This is fixed and this PR can be closed.

@bgrant0607 bgrant0607 closed this Jul 18, 2016
astoycos pushed a commit to astoycos/enhancements-1 that referenced this pull request Sep 27, 2021
Address comments for the KEP review
bart0sh pushed a commit to bart0sh/enhancements that referenced this pull request Jan 27, 2022
describe passing CDI device ids from kubelet to the CRI runtime
k8s-ci-robot pushed a commit that referenced this pull request Jun 17, 2022
add more details for livez and readyz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants