Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s/Design Proposal/KEP #687

Merged
merged 2 commits into from
Feb 8, 2019
Merged

s/Design Proposal/KEP #687

merged 2 commits into from
Feb 8, 2019

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jan 14, 2019

Drop the link to test plan, that should now be part of KEP

@spiffxp
s/Design Proposal/KEP
7d244e0 
Drop the link to test plan, that should now be part of KEP
@k8s-ci-robot k8s-ci-robot added sig/pm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 14, 2019
@spiffxp
Copy link
Member Author

spiffxp commented Jan 14, 2019

/cc @justaugustus

@justaugustus
Copy link
Member

/hold
Let's not drop the link until the KEP template is actually updated to explicitly include it.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2019
@idvoretskyi
Copy link
Member

/cc

idvoretskyi
idvoretskyi approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 15, 2019
@mattfarina
Copy link
Contributor

Just to record the action, prior to merging @justaugustus is asking the KEP template be updated to include the test plan as part of the graduation criteria or some other appropriate location. Or, that's what I read.

@spiffxp
Copy link
Member Author

spiffxp commented Jan 17, 2019

ref: #690 for KEP template update

@justaugustus
Copy link
Member

Yep. I'll release the hold on this once #703 merges.
/lgtm
/approve

@justaugustus
Copy link
Member

/remove-milestone v1.14
/milestone keps-beta

@k8s-ci-robot k8s-ci-robot added this to the keps-beta milestone Jan 20, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2019
@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idvoretskyi, justaugustus, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [idvoretskyi,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit cfc37c3 into kubernetes:master Feb 8, 2019
@spiffxp spiffxp deleted the s-design-proposal-kep branch February 11, 2019 17:48
@justaugustus justaugustus added area/enhancements Issues or PRs related to the Enhancements subproject and removed sig/pm labels Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@calebamiles calebamiles Awaiting requested review from calebamiles

@kacole2 kacole2 Awaiting requested review from kacole2

@justaugustus justaugustus Awaiting requested review from justaugustus

Assignees

@idvoretskyi idvoretskyi

@justaugustus justaugustus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
keps-beta
Development

Successfully merging this pull request may close these issues.
5 participants
@spiffxp @justaugustus @idvoretskyi @mattfarina @k8s-ci-robot