[KEP-5573]: follows up from review

[kannon92]

Address followups such as oom.group risk, calling out kubeadm as out of scope and renaming the top level folder to reflect the true name of the KEP.

[kannon92]

/assign @pacoxu @BenTheElder @dchen1107

[BenTheElder]

kubeadm already supports customizing kubelet config so I'm not sure if anything needs to be done here, updates to the preflight checks? docs?

kubeadm is a little bit weird because it's in-tree and used for release-blocking signal (similarly if the node_e2e or kube-up scripts didn't work we'd have a problem), I think calling out out-of-tree projects as out of scope is at least reasonable.

It's not super great to release k/k with the release binaries out of sync.

[BenTheElder]

The rest of the diff LGTM, not sure about this part.

[kannon92]

It's not super great to release k/k with the release binaries out of sync.

I don't follow what you mean here.

[kannon92]

kubeadm already supports customizing kubelet config so I'm not sure if anything needs to be done here, updates to the preflight checks? docs?

#5574 (comment)

[BenTheElder]

I don't follow what you mean here.

Saying "this kep won't wait for another core release binary to be ready" is a little different from "we're not going to block on out of tree projects updating", kubeadm is part of the core kubernetes release. We shouldn't release a broken state.

#5574 (comment)

I see ... commented

[pacoxu]

kubeadm is a little bit weird because it's in-tree and used for release-blocking signal (similarly if the node_e2e or kube-up scripts didn't work we'd have a problem), I think calling out out-of-tree projects as out of scope is at least reasonable.

That's true and we also have an issue to move it out which is not updated for a long time. #1424

https://github.com/kubernetes/system-validators/blob/a7fadf67da1228984480d7e8dd9c8ae39803a442/validators/cgroup_validator_linux.go#L117

		warns = append(warns, errors.New("cgroups v1 support is in maintenance mode, please migrate to cgroups v2"))

We have a warning message when cgroup v1 support went to maintenance mode.

After this change happened in kubelet, we will update it to an error IIUC. This will be tracked in kubernetes/system-validators#58.

[kannon92]

I took a stab at addressing this. I'm not entirely sure what the goal is for system-validators but I call that out as a goal for this KEP.

[SergeyKanzhelev]

/lgtm

[pacoxu]

/lgtm
/assign @dchen1107 @mrunalp

[SergeyKanzhelev]

re-lgtm the change

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, mrunalp, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/sig-node/OWNERS [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment