-
Notifications
You must be signed in to change notification settings - Fork 1.6k
promote kep-3673 to GA #5640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
promote kep-3673 to GA #5640
Conversation
/cc @ruiwen-zhao |
@pacoxu: GitHub didn't allow me to request PR reviews from the following users: ruiwen-zhao. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mrunalp, pacoxu, SergeyKanzhelev The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
||
#### GA | ||
|
||
- Change the default value of `serialize-image-pulls` to false and set the default value of `maxParallelImagePulls` to 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm - do we really want to change the default for "GA"?
With https://github.com/kubernetes/enhancements/tree/master/keps/sig-architecture/5241-beta-featuregate-promotion-requirements, we generally want the GA to effectively be kind of "no-op". Changing the default might be a bit unexpected here.
I know that it doesn't explicitly affect the user (it may affect them implicitly because some pods startup (due to image pulling) may be slower/faster), but still it might not be intuitive.
Let me ping other PRR approvers about it for their thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If so, should we make this step as beta-2 for this KEP to change the default?
One-line PR description: kep 3673 GA
Issue link: Kubelet limit of Parallel Image Pulls #3673
Other comments: for GA, we change default behavior to
serializeImagePulls: false
andmaxParallelImagePulls: 2
.