KEP-3104: Add kubectl kuberc command section

[ardaguclu]

• One-line PR description: Add kubectl kuberc command to generate kuberc files.

• Issue link:

  • Discussion link
  • Separate kubectl user preferences from cluster configs #3104

• Other comments:

[ardaguclu]

/hold
for PRR review

[ardaguclu]

for sig-cli
/cc @soltysh
for PRR
/cc @johnbelamaric

[soltysh]

I'd imagine that recommended options would be added on the first invocation, w/o any flag. Iow. I'm running kubectl kuberc (any of the sub-commands for the very first time. The user is presented with a question that there is not kuberc present and should we create one. Example flow below:

$ kubectl kuberc view
It seems you don't have a kuberc file, yet. Shall I create one with recommended options (Y/n): y
Default kuberc created in /home/maciej/.kube/kuberc

Similarly if user says No, we don't do anything.

[soltysh]

In other words, drop this flag entirely 😅

[ardaguclu]

It makes sense. I dropped the flag definition from the KEP. We can discuss the interactive behavior of recommended in the PR?

[soltysh]

Yeah, it doesn't have to be described in detail in this document.

[soltysh]

I wonder if we should replace kubectl kuberc default|alias with a more generic mechanism. #5479 adds a new section to kuberc, does that mean we should be adding more sub-commands for every section? I'm fully aware that not all sections will be supported, but at the same time I want to avoid the proliferation of sub-commands, just like we have currently under kubectl config.

What do you think about doing:

• kubectl kuberc set --section defaults --command=apply --option=server-side=true
• kubectl kuberc set --section aliases server-apply --command=apply --option=server-side=true

I'm aware that even with this approach we'll be required to expand the support for every section manually. Wdyt?

[ardaguclu]

I think, this is reasonable with one caveat;

kubectl kuberc set --section aliases server-apply --command=apply --option=server-side=true we need to extract the alias name server-apply from here. Cobra may not give this us easily (because alias name comes after the --section flag definition), so I proposed a --name flag for the easier mapping something like this;

kubectl kuberc set --section aliases --name server-apply --command=apply --option=server-side=true WDYT?.

[soltysh]

That sounds reasonable.

[soltysh]

Minor nits, we can update once we'll be updating this next time.
/lgtm
/approve

[soltysh]

Suggested change

	`kubectl kuberc set --section defaults` subcommand creates/updates the default values of commands. It has the following flags;
	`kubectl kuberc set --section defaults` subcommand creates/updates the default values of commands. It has the following flags:

[soltysh]

Yeah, it doesn't have to be described in detail in this document.

[soltysh]

That sounds reasonable.

[soltysh]

Suggested change

	`--appendarg` is an arbitrary list of strings that accepts anything in string array format.
	`--appendarg` is an arbitrary list of strings that accept anything in string array format.

[soltysh]

Suggested change

	`--prependarg` is an arbitrary list of strings that accepts anything in a string array format.
	`--prependarg` is an arbitrary list of strings that accept anything in a string array format.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• keps/sig-cli/OWNERS [ardaguclu,soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[soltysh]

/hold cancel

[soltysh]

/label tide/merge-method-squash