Skip to content

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Sep 17, 2025

Mark completed 1.34 sig-auth features as implemented

Closes #4601 #4633

/sig auth
/assign @enj @deads2k

@k8s-ci-robot k8s-ci-robot added sig/auth Categorizes an issue or PR as relevant to SIG Auth. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 17, 2025
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Sep 17, 2025
@k8s-ci-robot k8s-ci-robot requested a review from enj September 17, 2025 13:11
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 17, 2025
owning-sig: sig-auth
participating-sigs:
- sig-network
status: provisional
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enhancements/keps/prod-readiness/sig-auth/4940.yaml: no such file or directory

this didn't get marked as implementable, so never got a PRR review 🤦

will deal with that in a separate PR

@liggitt liggitt changed the title KEP-4601 / KEP-4633 / KEP-4940: Mark completed 1.34 sig-auth features as implemented KEP-4601 / KEP-4633: Mark completed 1.34 sig-auth features as implemented Sep 17, 2025
@enj enj added this to SIG Auth Sep 17, 2025
@enj enj moved this to Needs Triage in SIG Auth Sep 17, 2025
Copy link
Contributor

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 6971f16 into kubernetes:master Sep 29, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Sep 29, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed / Done in SIG Auth Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

Status: Closed / Done

Development

Successfully merging this pull request may close these issues.

Authorize with Field and Label Selectors

5 participants