KEP-2433: Graduate Topology Aware Hints with only the Hints field to GA #5151
Conversation
k8s-ci-robot
added
cncf-cla: yes
|
/assign @johnbelamaric (For PRR) |
k8s-ci-robot
added
the
lgtm
| @@ -3,3 +3,5 @@ alpha: | |||
| approver: "@wojtek-t" | |||
| beta: | |||
| approver: "@wojtek-t" | |||
| stable: | |||
| approver: "@wojtek-t" # TODO(gauravkghildiyal): Change if someone else is reviewing. | |||
There was a problem hiding this comment.
I was OOO for last 3 weeks, but taking a look now.
There was a problem hiding this comment.
Few minor comments, as I can't comment on unchanged lines
- "Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?"
It's been 3+ years in beta already so it's pretty late, but were some manual tests run? In any case, can you please update this subsection?
- I'm assuming that release team will ask you to update to the new KEP template, which in addition contains one new question in scalability section.
Other than that, this lgtm.
There was a problem hiding this comment.
I was OOO for last 3 weeks, but taking a look now.
Welcome back :)
I've addressed the comments. I checked the latest PRR and have included the additional questions which were missing.
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gauravkghildiyal, thockin, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
One-line PR description: Update KEP-2433 to indicate that only the
Hintsfield is planned to graduate to GA as part of this KEPIssue link: Topology Aware Routing #2433
Hintsgraduating while still maintaining all the valuable information present here. I didn't find that perfect balance and have started out with adding an explanatory note towards the beginning and some minor updates elsewhere. Happy to iterate on any feedback received./cc @robscott
/assign @aojea @danwinship @thockin