Skip to content

KEP-2902: Promote CPUManager policy option to distribute CPUs across NUMA nodes to Beta #5117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 7, 2025
Merged

KEP-2902: Promote CPUManager policy option to distribute CPUs across NUMA nodes to Beta #5117

merged 4 commits into from
Feb 7, 2025

Conversation

@swatisehgal
Copy link
Contributor

  • One-line PR description: Add CPUManager policy option to distribute CPUs across NUMA nodes instead of packing them
  • Other comments: Introduced as an alpha feature in v1.23

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2025
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 31, 2025
@swatisehgal swatisehgal changed the title KEP- 2902: Promote CPUManager policy option to distribute CPUs across NUMA nodes to Beta KEP-2902: Promote CPUManager policy option to distribute CPUs across NUMA nodes to Beta Jan 31, 2025
@swatisehgal swatisehgal mentioned this pull request Jan 31, 2025
Closed
12 tasks
mrunalp
mrunalp approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 3, 2025
@ffromani
Copy link
Contributor

ffromani commented Feb 5, 2025

LGTM for the content
question: are we compliant with the latest KEP template?

@ffromani
Copy link
Contributor

ffromani commented Feb 5, 2025

/lgtm

@swatisehgal
Copy link
Contributor Author

swatisehgal commented Feb 5, 2025 •
edited
Loading

LGTM for the content question: are we compliant with the latest KEP template?

Thanks for pointing this out, after looking closely I have noticed that some minor updates are needed. Will do that now.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 5, 2025
@swatisehgal swatisehgal force-pushed the distribute-cpus-across-numa-to-beta branch from bf50ada to 0dea904 Compare February 6, 2025 12:21
ffromani
ffromani reviewed Feb 7, 2025
View reviewed changes
Copy link
Contributor

@ffromani ffromani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sig-node: minor comments and clarification suggestions

@swatisehgal swatisehgal force-pushed the distribute-cpus-across-numa-to-beta branch from 93eb55a to 3638de8 Compare February 7, 2025 15:50
@swatisehgal swatisehgal force-pushed the distribute-cpus-across-numa-to-beta branch from 3638de8 to 8d095f4 Compare February 7, 2025 15:58
@johnbelamaric
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 7, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, mrunalp, swatisehgal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 06d6d0d into kubernetes:master Feb 7, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.33 milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 kannon92 left review comments

@mrunalp mrunalp mrunalp approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

+1 more reviewer

@ffromani ffromani ffromani left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mrunalp mrunalp

@johnbelamaric johnbelamaric

@ffromani ffromani

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v1.33

Development

Successfully merging this pull request may close these issues.

6 participants

@swatisehgal @ffromani @johnbelamaric @k8s-ci-robot @mrunalp @kannon92