Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP template: update link to integration tests #5103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP template: update link to integration tests #5103

wants to merge 1 commit into from

Conversation

gjtempleton
Copy link
Member

@gjtempleton gjtempleton commented Jan 29, 2025 •
edited
Loading

  • One-line PR description: Update broken git link to existing integration tests
  • Issue link: N/A
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gjtempleton
Once this PR has been reviewed and has the lgtm label, please assign jeremyrickard for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 29, 2025
@gjtempleton
Copy link
Member Author

/assign @jeremyrickard

@kikisdeliveryservice kikisdeliveryservice self-assigned this Feb 20, 2025
@kikisdeliveryservice
Copy link
Member

Thanks for the CL!

Looks good, currently holding template changes, will merge.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 20, 2025
@kikisdeliveryservice kikisdeliveryservice added kind/template Categorizes changes to the KEP template and removed kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Feb 20, 2025
@kikisdeliveryservice kikisdeliveryservice added this to the v1.34 milestone Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@kikisdeliveryservice kikisdeliveryservice

@jeremyrickard jeremyrickard

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/template Categorizes changes to the KEP template size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.34
Development

Successfully merging this pull request may close these issues.
4 participants
@gjtempleton @k8s-ci-robot @kikisdeliveryservice @jeremyrickard