Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP 1645: clarify port conflict rules #4887

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KEP 1645: clarify port conflict rules #4887

wants to merge 1 commit into from

Conversation

MrFreezeex
Copy link
Member

@MrFreezeex MrFreezeex commented Sep 30, 2024 •
edited
Loading

  • One-line PR description: Clarify port conflict rules based on Service port rules
  • Other comments: The existing version of the KEP doesn't state explicitly the associated Service port rules and what should be implemented is confusing here and prone to implementation errors.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 30, 2024
@MrFreezeex MrFreezeex force-pushed the kep1645-port-rules branch 2 times, most recently from 148e9a9 to 2aec509 Compare September 30, 2024 19:19
@MrFreezeex MrFreezeex mentioned this pull request Sep 30, 2024
Merged
@MrFreezeex
KEP 1645: clarify port conflict rules
012e81d 
Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
@thockin
Copy link
Member

thockin commented Sep 30, 2024

@lauralorenz @bowei

@skitt
Copy link
Member

skitt commented Oct 1, 2024

Thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, skitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@tpantelis tpantelis mentioned this pull request Oct 3, 2024
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpantelis tpantelis tpantelis left review comments

@JeremyOT JeremyOT Awaiting requested review from JeremyOT

@skitt skitt Awaiting requested review from skitt

Assignees

@bowei bowei

@lauralorenz lauralorenz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/multicluster Categorizes an issue or PR as relevant to SIG Multicluster. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MrFreezeex @thockin @skitt @k8s-ci-robot @tpantelis @bowei @lauralorenz