Skip to content

KEP-3998: Update the metrics and condition reason for the Beta graduation #4775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

KEP-3998: Update the metrics and condition reason for the Beta graduation #4775

merged 1 commit into from
Sep 19, 2024

Conversation

@tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jul 26, 2024

  • One-line PR description: Based on this discussion, I updated the jobs_finished_total metric reasons and the Complete and SuccessCriteriaMet condition reasons.
  • Other comments: I updated the e2e test cases with the actual e2e testing implementations.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot requested a review from kow3ns July 26, 2024 15:48
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Jul 26, 2024
@k8s-ci-robot k8s-ci-robot requested a review from soltysh July 26, 2024 15:48
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 26, 2024
@tenzen-y tenzen-y mentioned this pull request Jul 26, 2024
Closed
29 tasks
@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 26, 2024

I updated the JobSuccessPolicy Beta graduation KEP based on discussions during the implementation phase.
PTAL, thanks.

/assign @atiratree @mimowo @alculquicondor @soltysh

@mimowo
Copy link
Contributor

mimowo commented Jul 26, 2024

/lgtm
Thanks for updating the KEP to align the decisions made during the implementation phase

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2024
@tenzen-y
Copy link
Member Author

tenzen-y commented Sep 17, 2024

@soltysh Could you take a look at this? Thanks!

soltysh
soltysh reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel
minor nits, and this is good to land, please ping me on slack when you get this updated :-)

keps/sig-apps/3998-job-success-completion-policy/kep.yaml

# The following PRR answers are required at beta release
metrics:
- job_succeeded_total
Copy link
Contributor

@soltysh soltysh Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should state jobs_finished_total based on the update, not a removal of a metric, which is one of the requirement for almost every enhancement.

Copy link
Contributor

@soltysh soltysh Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't mean it has to be new metrics, but ones that are relevant for observing the state of the cluster after the feature is being used. With that I'd also add job_sync_duration_seconds which you mentioned in the SLI section of the enhancement.

Copy link
Member Author

@tenzen-y tenzen-y Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know that. Thank you for the kindly guidance.

Copy link
Member Author

@tenzen-y tenzen-y Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

Copy link
Contributor

@mimowo mimowo Sep 18, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, I think jobs_finished_total should still be added to the list per first comment

Copy link
Member Author

@tenzen-y tenzen-y Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Thanks.
I added that.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 18, 2024
@tenzen-y tenzen-y force-pushed the update-beta-updating-3998 branch from f537c36 to e060145 Compare September 18, 2024 15:23
@tenzen-y tenzen-y force-pushed the update-beta-updating-3998 branch from e060145 to 893cd43 Compare September 18, 2024 16:17
mimowo
mimowo reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mimowo mimowo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

soltysh
soltysh approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2024
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2024
@k8s-ci-robot k8s-ci-robot merged commit 66b1e3c into kubernetes:master Sep 19, 2024
@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Sep 19, 2024
@tenzen-y tenzen-y deleted the update-beta-updating-3998 branch September 19, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

+1 more reviewer

@mimowo mimowo mimowo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@alculquicondor alculquicondor

@atiratree atiratree

@mimowo mimowo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

SIG Apps
Archived in project

Milestone

v1.32

Development

Successfully merging this pull request may close these issues.

6 participants

@tenzen-y @mimowo @k8s-ci-robot @soltysh @alculquicondor @atiratree