Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP 1645: update conditions in ServiceExport after KEP-1623 #4672

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

KEP 1645: update conditions in ServiceExport after KEP-1623 #4672

wants to merge 2 commits into from

Commits on Oct 1, 2024

  1. KEP 1645: update conditions in ServiceExport after KEP-1623 

    Also swap the "2/5 cluster disagree" in the conflict message so that it's
clear that the disagree sentence is for the service we export and not from
the oldest Service that we conflict with.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
    @MrFreezeex
    MrFreezeex committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    66513d7 View commit details
    Browse the repository at this point in the history

  2. KEP 1645: add ServiceExportLocalConflict condition on ServiceExport 

    Add extra information to indicate to the user via the new
ServiceExportLocalConflict condition if the local service export is directly
involved in the conflict. As ServiceExportConflict should be added on every
ServiceExport involved whether or not the local service export is involved,
users were not involved to grasp that information without manually checking
the service exported on multiple clusters.

Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
    @MrFreezeex
    MrFreezeex committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    66d3f05 View commit details
    Browse the repository at this point in the history