Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3983: target to beta for 1.30 #4419

Merged
merged 1 commit into from
Feb 1, 2024
Merged

KEP-3983: target to beta for 1.30 #4419

merged 1 commit into from
Feb 1, 2024

Conversation

sohankunkerkar
Copy link
Member

  • One-line PR description: Updates target for KEP to beta in 1.30
  • Other comments:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 19, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @sohankunkerkar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 19, 2024
@sohankunkerkar
Copy link
Member Author

cc @haircommander

@haircommander haircommander mentioned this pull request Jan 19, 2024
Open
8 tasks
@haircommander
Copy link
Contributor

/ok-to-test

LGTM

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 19, 2024
@sohankunkerkar sohankunkerkar force-pushed the update-3983 branch 2 times, most recently from 23f9d12 to 6d5897b Compare January 22, 2024 14:09
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2024
sohankunkerkar added a commit to sohankunkerkar/kubernetes that referenced this pull request Jan 22, 2024
@sohankunkerkar
*: prepare KubeletConfigDropInDir feature to beta
0a44de1 
This change removes the environment variable set during
the Alpha phase and prepares the feature for beta graduation.

xref: kubernetes/enhancements#4419

Signed-off-by: Sohan Kunkerkar <[email protected]>
@sohankunkerkar sohankunkerkar mentioned this pull request Jan 22, 2024
Merged
@sohankunkerkar sohankunkerkar force-pushed the update-3983 branch 2 times, most recently from 009e128 to 2f11c72 Compare January 22, 2024 17:38
@haircommander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024
sohankunkerkar added a commit to sohankunkerkar/kubernetes that referenced this pull request Jan 23, 2024
@sohankunkerkar
*: prepare KubeletConfigDropInDir feature to beta
03f5594 
This change removes the environment variable set during
the Alpha phase and prepares the feature for beta graduation.

xref: kubernetes/enhancements#4419

Signed-off-by: Sohan Kunkerkar <[email protected]>
@sohankunkerkar
KEP-3983: target to beta for 1.30
8b8abfc 
Signed-off-by: Sohan Kunkerkar <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2024
@haircommander
Copy link
Contributor

still
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2024
SergeyKanzhelev
SergeyKanzhelev reviewed Feb 1, 2024
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

please note, there are many graduation criterias that are docs-bound. So please start implementation with documenting things before changing any code.

One specific example I want to see - can I add a drop-in file to add or disable a feature gate. Same for any other multi-value strictures might be there

mrunalp
mrunalp approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ensure that the documentation accurately captures the nuances and edge cases of how we handle the merges.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrunalp, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 0e09fd6 into kubernetes:master Feb 1, 2024
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Feb 1, 2024
@sohankunkerkar
Copy link
Member Author

One specific example I want to see - can I add a drop-in file to add or disable a feature gate. Same for any other multi-value strictures might be there

Thanks for the suggestion. I will update this information here and this place too.

@sohankunkerkar sohankunkerkar mentioned this pull request Feb 1, 2024
Closed
@sohankunkerkar sohankunkerkar deleted the update-3983 branch February 1, 2024 23:12
sohankunkerkar added a commit to sohankunkerkar/kubernetes that referenced this pull request Mar 1, 2024
@sohankunkerkar
*: promote KubeletConfigDropInDir feature to beta
5ad06c7 
This change removes the environment variable set during
the Alpha phase and prepares the feature for beta graduation.

xref: kubernetes/enhancements#4419

Signed-off-by: Sohan Kunkerkar <[email protected]>
sohankunkerkar added a commit to sohankunkerkar/kubernetes that referenced this pull request Mar 1, 2024
@sohankunkerkar
*: promote KubeletConfigDropInDir feature to beta
b40b5f8 
This change removes the environment variable set during
the Alpha phase and prepares the feature for beta graduation.

xref: kubernetes/enhancements#4419

Signed-off-by: Sohan Kunkerkar <[email protected]>
dinhxuanvu pushed a commit to dinhxuanvu/kubernetes that referenced this pull request Mar 28, 2024
@sohankunkerkar @dinhxuanvu
*: promote KubeletConfigDropInDir feature to beta
33b955b 
This change removes the environment variable set during
the Alpha phase and prepares the feature for beta graduation.

xref: kubernetes/enhancements#4419

Signed-off-by: Sohan Kunkerkar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@mrunalp mrunalp mrunalp approved these changes

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@haircommander haircommander

@SergeyKanzhelev SergeyKanzhelev

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
SIG Node PR Triage
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.
6 participants
@sohankunkerkar @k8s-ci-robot @haircommander @mrunalp @kannon92 @SergeyKanzhelev