Skip to content

Update KEP3850 "BackoffLimitPerIndex for Indexed Jobs" #4321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

Update KEP3850 "BackoffLimitPerIndex for Indexed Jobs" #4321

merged 1 commit into from
Nov 2, 2023

Conversation

@mimowo
Copy link
Contributor

@mimowo mimowo commented Oct 30, 2023

  • One-line PR description: Update KEP3850 "BackoffLimitPerIndex for Indexed Jobs"
  • Other comments: Updated e2e tests and benchmark tests.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels Oct 30, 2023
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Oct 30, 2023
@mimowo
Copy link
Contributor Author

mimowo commented Oct 30, 2023

/assign @alculquicondor @soltysh

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 30, 2023
@mimowo mimowo mentioned this pull request Oct 30, 2023
Merged
alculquicondor
alculquicondor reviewed Oct 31, 2023
View reviewed changes
Copy link
Member

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2023
@jensentanlo jensentanlo mentioned this pull request Nov 2, 2023
Closed
12 tasks
@mimowo mimowo force-pushed the backoff-limit-per-index-update-kep-beta branch from efde669 to 7cebcdf Compare November 2, 2023 15:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2023
soltysh
soltysh approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 2, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit b9ae0aa into kubernetes:master Nov 2, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Nov 2, 2023
@mimowo mimowo deleted the backoff-limit-per-index-update-kep-beta branch February 10, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@kow3ns kow3ns Awaiting requested review from kow3ns

+1 more reviewer

@alculquicondor alculquicondor alculquicondor left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@alculquicondor alculquicondor

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

SIG Apps
Archived in project

Milestone

v1.29

Development

Successfully merging this pull request may close these issues.

4 participants

@mimowo @k8s-ci-robot @soltysh @alculquicondor