Memory QoS Beta Update and Production Readiness #4093
Merged
+40
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
kind/kep
ndixita
force-pushed
the
memory-qos-beta
branch
2 times, most recently
from
35e2887
to
f90865e
Compare
pacoxu
reviewed
Jun 15, 2023
pacoxu
reviewed
Jun 15, 2023
|
/retest |
|
/lgtm Thank you for the updates! /assign @mrunalp |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
| @@ -538,7 +546,7 @@ Pick one of these and delete the rest. | |||
| Any change of default behavior may be surprising to users or break existing | |||
| automations, so be extremely careful here. | |||
| --> | |||
| Yes, the kubelet will set `memory.min` for Guaranteed and Burstable pod/container level cgroup. It also will set `memory.high` for burstable container, which may cause memory allocation throttle. `memory.min` for qos or node level cgroup will be set when `--cgroups-per-qos` or `--enforce-node-allocatable` is satisfied. | |||
| Yes, the kubelet will set `memory.min` for Guaranteed and Burstable pod/container level cgroup. It also will set `memory.high` for burstable and best effort containers, which may cause memory allocation throttle. `memory.min` for qos or node level cgroup will be set when `--cgroups-per-qos` or `--enforce-node-allocatable` is satisfied. | |||
There was a problem hiding this comment.
How will this throttling impact the workloads? (you can answer here or below).
k8s-ci-robot
removed
the
lgtm
|
/lgtm lgtm on the recent updates, and adding new metric in beta as suggested in #4093 (comment) |
k8s-ci-robot
added
the
lgtm
|
Ok, PRR seems fine but it does need SIG approval still |
|
/assign @SergeyKanzhelev |
SergeyKanzhelev
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
/lgtm
/approve
@johnbelamaric this lgtm, I'll find official approver shortly
|
/lgtm |
mrunalp
approved these changes
Jun 15, 2023
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dchen1107, johnbelamaric, mrunalp, ndixita, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line PR description: Update KEP for Beta implementation of MemoryQoS feature
Issue link: Support memory qos with cgroups v2 #2570
/assign @bobbypage
/assign @johnbelamaric
/assign @mrunalp
/assign @pacoxu