Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-4020: Unknown Version Interoperability Proxy : Remove uvip acronym from metrics/headers #4074

Merged
merged 1 commit into from
Jun 9, 2023
Merged

KEP-4020: Unknown Version Interoperability Proxy : Remove uvip acronym from metrics/headers #4074

merged 1 commit into from
Jun 9, 2023

Conversation

richabanker
Copy link
Contributor

  • One-line PR description: Amends the metrics and headers described in the KEP

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 9, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 9, 2023
@richabanker
Copy link
Contributor Author

richabanker commented Jun 9, 2023 •
edited
Loading

cc @jpbetz

@jpbetz
Copy link
Contributor

jpbetz commented Jun 9, 2023

/lgtm
/approve

This is a good start for name selection. Anyone that has suggestions- please feel free to voice them. We don't consider names picked in the KEP final. API reviewers can veto, and we should feel empowered during implementation to strive to improve how things are named.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 9, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpbetz, Richabanker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4ed4104 into kubernetes:master Jun 9, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 9, 2023
@richabanker richabanker deleted the UVIP branch June 9, 2023 17:08
@richabanker richabanker mentioned this pull request Jun 9, 2023
Merged
@Atharva-Shinde Atharva-Shinde mentioned this pull request Jun 15, 2023
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@fedebongio fedebongio Awaiting requested review from fedebongio

Assignees

@jpbetz jpbetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
3 participants
@richabanker @jpbetz @k8s-ci-robot