Skip to content

add GA requirement for extending metrics stability #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

add GA requirement for extending metrics stability #4041

merged 1 commit into from
Jun 1, 2023

Conversation

@logicalhan
Copy link
Member

@logicalhan logicalhan commented May 29, 2023

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory labels May 29, 2023
@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 29, 2023
@logicalhan
Copy link
Member Author

logicalhan commented May 29, 2023

/retest

@logicalhan
Copy link
Member Author

logicalhan commented May 29, 2023

failing test due to kubernetes/test-infra#29622

@wojtek-t wojtek-t self-assigned this May 30, 2023
@wojtek-t
Copy link
Member

wojtek-t commented Jun 1, 2023

/lgtm
/approve PRR

Thanks!

/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2023
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logicalhan, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 80de492 into kubernetes:master Jun 1, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 1, 2023
@Atharva-Shinde Atharva-Shinde mentioned this pull request Jun 15, 2023
Closed
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dashpole dashpole Awaiting requested review from dashpole

@dgrisonnet dgrisonnet Awaiting requested review from dgrisonnet

Assignees

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.28

Development

Successfully merging this pull request may close these issues.

3 participants

@logicalhan @wojtek-t @k8s-ci-robot