Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update KEP for Kubelet Resource Metrics endpoint GA release #4037

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Update KEP for Kubelet Resource Metrics endpoint GA release #4037

merged 1 commit into from
Oct 3, 2023

Conversation

richabanker
Copy link
Contributor

@richabanker richabanker commented May 27, 2023 •
edited
Loading

  • One-line PR description: Migrate KEP to latest template, mark requirements for beta and GA release as checked

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 27, 2023
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label May 27, 2023
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2023
@richabanker richabanker mentioned this pull request May 27, 2023
Closed
10 tasks
@richabanker richabanker force-pushed the kubelet-resource-metrics-kep branch from 1f7a527 to 072e084 Compare May 27, 2023 01:27
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2023
@bart0sh
Copy link
Contributor

bart0sh commented May 29, 2023

/cc @SergeyKanzhelev @mrunalp

@marquiz
Copy link
Contributor

marquiz commented Jun 9, 2023

Do we care about the KEP template at this point?

wojtek-t
wojtek-t reviewed Jun 11, 2023
View reviewed changes
keps/sig-node/727-resource-metrics-endpoint/README.md Outdated
@@ -202,11 +202,11 @@ Alpha:

Beta:

- [ ] Modify the metrics server to consume the kubelet resource metrics endpoint 3 releases after it is added to the kubelet
- [X] Modify the metrics server to consume the kubelet resource metrics endpoint 3 releases after it is added to the kubelet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update kep.yaml and ask for prod-readiness review

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated kep.yaml. Will ask for PRR once the questionnaire is completed.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 12, 2023
@richabanker
Copy link
Contributor Author

Do we care about the KEP template at this point?

I have migrated the KEP to the latest template.

@richabanker richabanker force-pushed the kubelet-resource-metrics-kep branch 4 times, most recently from 3a28822 to 6e34578 Compare September 8, 2023 23:31
@wojtek-t wojtek-t self-assigned this Sep 19, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 23, 2023
wojtek-t
wojtek-t reviewed Oct 2, 2023
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments - PTAL

[Overall, we didn't do the good job in the past, so there is not much more we can do now]

keps/sig-node/727-resource-metrics-endpoint/README.md Show resolved Hide resolved
keps/sig-node/727-resource-metrics-endpoint/README.md Outdated

###### Can the feature be disabled once it has been enabled (i.e. can we roll back the enablement)?

No, this feature can not be disabled once it has been enabled since we do not have a feature flag for this. To rollback, one will have to downgrade the kubernetes version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added in 1.14, right? So effectively there is no way to downgrade at this point even...

Please add a release in which it was added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks for pointing that out.

keps/sig-node/727-resource-metrics-endpoint/README.md Outdated

###### Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?

No
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given it's "always enabled" for last 14 releases, it's too late now.

Let's maybe make it clear, sth like

"It was enabled (with no way to disable) since 1.14."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

keps/sig-node/727-resource-metrics-endpoint/kep.yaml Show resolved Hide resolved
@richabanker richabanker force-pushed the kubelet-resource-metrics-kep branch 4 times, most recently from e79fd50 to 5e8b990 Compare October 2, 2023 18:58
@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 2, 2023
johnbelamaric
johnbelamaric reviewed Oct 2, 2023
View reviewed changes
keps/sig-node/727-resource-metrics-endpoint/README.md

GA:

- [X] Add [node-e2e test](https://github.com/kubernetes/kubernetes/pull/116897/files#diff-3859a7587ac4b3d1e162a2360b1fd2d3e88d4589be9b0bf19029fa7489294796R59-R70)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as a note: previously this asked for conformance, but kubelet APIs cannot be part of conformance. See kubernetes/kubernetes#120473 (comment)

@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 2, 2023
@wojtek-t
Copy link
Member

wojtek-t commented Oct 3, 2023

/lgtm
/approve PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, Richabanker, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5844db9 into kubernetes:master Oct 3, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wojtek-t wojtek-t wojtek-t left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev left review comments

@johnbelamaric johnbelamaric johnbelamaric left review comments

@dashpole dashpole dashpole left review comments

@pacoxu pacoxu pacoxu left review comments

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

@mrunalp mrunalp Awaiting requested review from mrunalp

Assignees

@dchen1107 dchen1107

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Node: code and documentation PRs
Archived in project
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
10 participants
@richabanker @bart0sh @marquiz @dchen1107 @wojtek-t @k8s-ci-robot @pacoxu @dashpole @johnbelamaric @SergeyKanzhelev