-
Notifications
You must be signed in to change notification settings - Fork 1.6k
KEP-1440: Promote kubectl events command to stable #4018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1440: Promote kubectl events command to stable #4018
Conversation
00eb9a4 to
e6f5b0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit and this is good to go
| ##### GA | ||
|
|
||
| - [ ] Address all major issues and bugs raised by community members | ||
| - [x] Address all major issues and bugs raised by community members |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
e2e tests section above says missing but we already have tests, can you provide link to test-grid ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/label tide/merge-method-squash
/assign @wojtek-t
for PRR approval
|
/lgtm |
|
@wojtek-t would you mind taking a look at this promotion KEP?. Thanks. |
|
Queued - will take a look in the next few days. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu, soltysh, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
One-line PR description: promote kubectl events to stable
Issue link: kubectl events #1440
Other comments: none
/assign @soltysh @eddiezane
for sig-cli review
/assign @wojtek-t
for prr review