Skip to content

Conversation

@ardaguclu
Copy link
Member

@ardaguclu ardaguclu commented May 17, 2023

  • One-line PR description: promote kubectl events to stable

  • Issue link: kubectl events #1440

  • Other comments: none

/assign @soltysh @eddiezane
for sig-cli review
/assign @wojtek-t
for prr review

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2023
@k8s-ci-robot k8s-ci-robot requested review from seans3 and soltysh May 17, 2023 11:51
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 17, 2023
@ardaguclu ardaguclu force-pushed the promoto-events-to-stable branch from 00eb9a4 to e6f5b0a Compare May 17, 2023 11:55
@soltysh soltysh mentioned this pull request May 18, 2023
12 tasks
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit and this is good to go

##### GA

- [ ] Address all major issues and bugs raised by community members
- [x] Address all major issues and bugs raised by community members
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

e2e tests section above says missing but we already have tests, can you provide link to test-grid ?

Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/label tide/merge-method-squash
/assign @wojtek-t
for PRR approval

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels May 18, 2023
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2023
@soltysh
Copy link
Contributor

soltysh commented May 30, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 30, 2023
@ardaguclu
Copy link
Member Author

@wojtek-t would you mind taking a look at this promotion KEP?. Thanks.

@wojtek-t
Copy link
Member

wojtek-t commented Jun 1, 2023

Queued - will take a look in the next few days.

@wojtek-t
Copy link
Member

wojtek-t commented Jun 1, 2023

/lgtm
/approve PRR

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, soltysh, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 1, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5586910 into kubernetes:master Jun 1, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Jun 1, 2023
@ardaguclu ardaguclu deleted the promoto-events-to-stable branch June 1, 2023 14:29
Copy link

@vicspina vicspina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants