-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KEP-1645: make endpointslices optional, but structure required if they exist #3950
KEP-1645: make endpointslices optional, but structure required if they exist #3950
Conversation
lauralorenz
commented
Apr 10, 2023
- One-line PR description: KEP-1645: make endpointslices optional, but structure required if they exist
- Issue link: Multi-Cluster Services API #1645
- Other comments: Moves section on EndpointSlices lower and add rationale on how they are optional, but required to conform to a specific format if they exist. This is following SIG-MC discussion on 3/21; see also the proposal doc here.
Signed-off-by: lauralorenz <[email protected]>
### EndpointSlices | ||
|
||
_Optional to create, but specification defined if present._ | ||
|
||
#### EndpointSlice | ||
The specific mechanism by which the `mcs-controller` maintains references to the | ||
individual backends for an aggregated service is an implementation detail not | ||
fully prescribed by this specification. Implementations may depend on a higher | ||
level (possibly vendor-specific) API, offload to a load balancer or xDS server | ||
(like Envoy), or use Kubernetes networking APIs. | ||
|
||
If an implementation does create `discovery.k8s.io/v1 EndpointSlice`s, they must | ||
conform to the following structure. This structure was originally required as | ||
part of this specification in alpha, and are the structure on which other | ||
SIG-endorsed reference implementations and tooling, like the [CoreDNS | ||
multicluster plugin](https://github.com/coredns/multicluster/), depend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI this section is the only new words; everything else is just moved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lauralorenz! I agree with this direction but have a few nits.
keps/sig-multicluster/1645-multi-cluster-services-api/README.md
Outdated
Show resolved
Hide resolved
keps/sig-multicluster/1645-multi-cluster-services-api/README.md
Outdated
Show resolved
Hide resolved
keps/sig-multicluster/1645-multi-cluster-services-api/README.md
Outdated
Show resolved
Hide resolved
Signed-off-by: lauralorenz <[email protected]>
🙏 thank you, addressed all in 7771e7a |
Signed-off-by: lauralorenz <[email protected]>
/cc jeremyot |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JeremyOT, lauralorenz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |