Skip to content

KEP-2595: Promote to the GA stage #3914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2023
Merged

KEP-2595: Promote to the GA stage #3914

merged 1 commit into from
May 31, 2023

Conversation

@gjkim42
Copy link
Member

@gjkim42 gjkim42 commented Mar 19, 2023

  • One-line PR description: Promote ExpandedDNSConfig to the GA stage.
  • Other comments:

/uncc all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 19, 2023
@aojea
Copy link
Member

aojea commented Apr 8, 2023

I think you need to add the PRR section based on the errors

@gjkim42 gjkim42 force-pushed the 2595-promote-to-ga branch from 5091fd6 to 1168101 Compare April 10, 2023 11:04
@gjkim42 gjkim42 changed the title WIP: KEP-2595: Promote to the GA stage KEP-2595: Promote to the GA stage Apr 10, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 10, 2023
@gjkim42
Copy link
Member Author

gjkim42 commented Apr 10, 2023

I think you need to add the PRR section based on the errors

thanks, updated it.

@aojea
Copy link
Member

aojea commented Apr 11, 2023

/lgtm
/assign @thockin @johnbelamaric

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2023
thockin
thockin reviewed Apr 11, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

This was referenced Apr 12, 2023
Closed
Merged
thockin
thockin reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRR: no functional changes in 2 releases and no issues filed.

/lgtm
/approve

@aojea
Copy link
Member

aojea commented Apr 15, 2023

ping @johnbelamaric this needs PRR approval

SergeyKanzhelev
SergeyKanzhelev reviewed Apr 21, 2023
View reviewed changes
@gjkim42 gjkim42 force-pushed the 2595-promote-to-ga branch from 1168101 to 373df25 Compare April 22, 2023 03:43
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 22, 2023
@gjkim42 gjkim42 force-pushed the 2595-promote-to-ga branch 4 times, most recently from 7fb35db to e5743bb Compare April 22, 2023 03:58
SergeyKanzhelev
SergeyKanzhelev reviewed Apr 24, 2023
View reviewed changes
SergeyKanzhelev
SergeyKanzhelev reviewed Apr 24, 2023
View reviewed changes
@gjkim42 gjkim42 force-pushed the 2595-promote-to-ga branch from e5743bb to 0e39d90 Compare April 25, 2023 15:13
@gjkim42 gjkim42 force-pushed the 2595-promote-to-ga branch from 0e39d90 to c710c9c Compare April 26, 2023 13:29
SergeyKanzhelev
SergeyKanzhelev approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
@gjkim42
Copy link
Member Author

gjkim42 commented Apr 27, 2023

PRR: no functional changes in 2 releases and no issues filed.

@johnbelamaric
Could you PTAL? We need PRR approval here.

@johnbelamaric
Copy link
Member

johnbelamaric commented May 31, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjkim42, johnbelamaric, SergeyKanzhelev, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit 63cae27 into kubernetes:master May 31, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 31, 2023
@gjkim42 gjkim42 deleted the 2595-promote-to-ga branch May 31, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pohly pohly pohly left review comments

@thockin thockin thockin left review comments

@aojea aojea aojea left review comments

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

Assignees

@thockin thockin

@aojea aojea

@johnbelamaric johnbelamaric

@SergeyKanzhelev SergeyKanzhelev

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.28

Development

Successfully merging this pull request may close these issues.

7 participants

@gjkim42 @aojea @johnbelamaric @k8s-ci-robot @pohly @thockin @SergeyKanzhelev