KEP-3705: simplify initial alpha, discuss possible changes to plan#3898
Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom Apr 14, 2023
Merged
Conversation
k8s-ci-robot
added
sig/network
danwinship
force-pushed
the
cloud-node-ips-alpha1
branch
from
09ee5bb to
0a7c39c
Compare
This was referenced Mar 6, 2023
Also update feature gate name
danwinship
force-pushed
the
cloud-node-ips-alpha1
branch
from
0a7c39c to
dd4fcdf
Compare
Contributor
Author
|
/assign @thockin |
thockin
reviewed
Apr 14, 2023
Member
thockin
left a comment
thockin
left a comment
There was a problem hiding this comment.
I'm glad you're able to keep this area in your brain, because...whew! Quite a tangle.
/lgtm
/approve
k8s-ci-robot
added
the
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line PR description: Update KEP-3705 to simplify what we will do in 1.27.
Issue link: Cloud Dual-Stack --node-ip Handling #3705
Other comments:
While starting to implement the new dual-stack cloud
--node-ipbehavior, I realized that the constraint of preserving backward-compatible behavior for all existing--node-ipvalues means that you can't express certain things in some clusters, depending on the set of NodeAddresses provided by the cloud. (See the commit for an example.)There are various things we could do about this, but it's too late to debate them in the 1.27 cycle. However, we know that we want to support explicit-dual-stack IPs on clouds; we know how we want to support it (using the same syntax we use for bare metal); and we know there are already people waiting for this functionality who would be sad if it missed 1.27.
So this PR updates the KEP to indicate that we're doing just that (explicit dual-stack
--node-ipon external clouds, without the originally-proposed newIPv4andIPv6literals) for 1.27, and that we'll update the KEP again in the 1.28 cycle after reconsidering the plan.(Where "update the KEP again" could mean saying "ok, never mind, we'll just continue with what we originally planned", but I think I'm going to suggest reducing this KEP to just the explicit-dual-stack-IPs part, and then file a new KEP proposing we deprecate
--node-ipin favor of--node-ipswith better semantics, and tie the annotation renaming to that as well.)/sig network
/cc @thockin @aojea @mdbooth @JoelSpeed