Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-1885: Update Azure File csi migration #3360

Merged
merged 7 commits into from
Sep 30, 2022

Conversation

andyzhangx
Copy link
Member

  • One-line PR description: Update Azure File csi migration test plan

cc @Jiawei0227 @msau42 @xing-yang

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jun 8, 2022
@gnufied
Copy link
Member

gnufied commented Jun 8, 2022

Please note Azurefile migration should not be marked as GA until #3363 feature goes GA too. Without #3363 feature, users can't read/write azurefile volumes unless they are either root or volume has 777 permissions.

@andyzhangx
Copy link
Member Author

Please note Azurefile migration should not be marked as GA until #3363 feature goes GA too. Without #3363 feature, users can't read/write azurefile volumes unless they are either root or volume has 777 permissions.

@gnufied sure, I have removed the GA word in test plan. PTAL, thanks.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 10, 2022
@xing-yang
Copy link
Contributor

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 16, 2022
@andyzhangx andyzhangx changed the title KEP-1885: Update Azure File csi migration test plan KEP-1885: Update Azure File csi migration Sep 16, 2022
@xing-yang
Copy link
Contributor

@xing-yang
Copy link
Contributor

@wojtek-t wojtek-t self-assigned this Sep 22, 2022
@wojtek-t
Copy link
Member

I'm fine with this from PRR POV, but you need SIG approval first.

@andyzhangx
Copy link
Member Author

@andyzhangx Have you run in-tree volumes tests?

https://github.com/kubernetes/kubernetes/blob/master/test/e2e/storage/in_tree_volumes.go

@bertinatto do you have the passing tests logs for in-tree azure file tests? related to kubernetes/kubernetes#106678

@xing-yang
Copy link
Contributor

xing-yang commented Sep 28, 2022

@bertinatto I don't see the "In-tree Volumes" label in the test like what you have shown here: kubernetes/kubernetes#106678 (comment)

@bertinatto
Copy link
Member

@bertinatto I don't see the "In-tree Volumes" label in the test like what you have shown here: kubernetes/kubernetes#106678 (comment)

I'm sorry, wrong link. Here's a testgrid link:

https://testgrid.k8s.io/redhat-openshift-ocp-release-4.12-blocking#aggregated-azure-ovn-upgrade-4.12-micro-release-openshift-release-analysis-aggregator

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2022
@xing-yang
Copy link
Contributor

/assign @wojtek-t
for PRR approval

@wojtek-t
Copy link
Member

/lgtm
/approve PRR

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, wojtek-t, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 32dc3a2 into kubernetes:master Sep 30, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 30, 2022
ahmedtd pushed a commit to ahmedtd/enhancements that referenced this pull request Feb 2, 2023
* KEP-1885: Update Azure File csi migration test plan

revert kep.yaml

fix

fix comments

* set as stable

* use beta version

* Update 1885.yaml

* Update README.md

* Update kep.yaml

* Update kep.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants