Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graduate release artifact signing to beta #3323

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

saschagrunert
Copy link
Member

Updating the release artifact signing KEP to beta.

Refers to #3031

cc @kubernetes/sig-release-leads @kubernetes/sig-release @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 30, 2022
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/release Categorizes an issue or PR as relevant to SIG Release. labels May 30, 2022
@saschagrunert saschagrunert mentioned this pull request May 30, 2022
7 tasks
Copy link
Member

@puerco puerco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I would do a small change here. The change suggested below is just for defining what we consider to be beta: We can sign both files and images.

My thinking now is that for GA we should enlist a concrete set of artifacts we'd like to sign and graduate the KEP when done (ie attestations from the promoter, stage provenance, release provenance, etc).

keps/sig-release/3031-signing-release-artifacts/README.md Outdated Show resolved Hide resolved
@saschagrunert
Copy link
Member Author

@kubernetes/sig-release PTAL

@puerco
Copy link
Member

puerco commented Jun 15, 2022

Thanks @saschagrunert !
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 15, 2022
Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@saschagrunert
Copy link
Member Author

/assign @johnbelamaric

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
/approve
/lgtm

@saschagrunert
Copy link
Member Author

@kubernetes/prod-readiness-reviewers PTAL

@johnbelamaric
Copy link
Member

Sorry, this isn't on the KEP enhancements sheets so I did not see it until now. Just luck that I saw it in fact...

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, johnbelamaric, justaugustus, puerco, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit bf60847 into kubernetes:master Jun 22, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 22, 2022
@saschagrunert saschagrunert deleted the signing-beta branch June 22, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants