Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP-3243: respect pod topology spread after rolling upgrades #3244

Merged
merged 5 commits into from
Jun 8, 2022
Merged

KEP-3243: respect pod topology spread after rolling upgrades #3244

merged 5 commits into from
Jun 8, 2022

Conversation

denkensk
Copy link
Member

@denkensk denkensk commented Mar 18, 2022 •
edited
Loading

Signed-off-by: Alex Wang [email protected]

  • One-line PR description: adding new KEP

Discussion Link
kubernetes/kubernetes#98215
kubernetes/kubernetes#105661

  • Other comments:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 18, 2022
@k8s-ci-robot k8s-ci-robot requested a review from ahg-g March 18, 2022 09:04
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Mar 18, 2022
@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Mar 18, 2022
@denkensk
Copy link
Member Author

/cc @ahg-g @Huang-Wei @alculquicondor

@denkensk denkensk mentioned this pull request Mar 18, 2022
Open
8 tasks
@alculquicondor
Copy link
Member

Thanks!
I will review after code freeze

@ahg-g
Copy link
Member

ahg-g commented Mar 18, 2022

Can you link the discussion issue please.

/assign

@denkensk
Copy link
Member Author

Can you link the discussion issue please.

Done. Added in the top.

@alculquicondor
Copy link
Member

/unassign
Since I already reviewed the doc, one KEP reviewer should be enough.

ahg-g
ahg-g reviewed Apr 27, 2022
View reviewed changes
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md Show resolved Hide resolved
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md Outdated Show resolved Hide resolved
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/kep.yaml Outdated Show resolved Hide resolved
keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/kep.yaml Outdated Show resolved Hide resolved
@denkensk denkensk force-pushed the respect-pod-topology-spread-after-rolling-upgrades branch from 3be0398 to cb1e11d Compare April 29, 2022 04:04
@denkensk
Copy link
Member Author

@ahg-g
Thanks for your review. Updated. Pls review it again.

@wojtek-t wojtek-t self-assigned this Apr 29, 2022
@denkensk
Copy link
Member Author

denkensk commented May 6, 2022

@ahg-g
Thanks a lot.
Updated.
Pls review it again.

@ahg-g
Copy link
Member

ahg-g commented May 6, 2022

/lgtm

@wojtek-t this should be ready for PRR

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2022
wojtek-t
wojtek-t reviewed Jun 7, 2022
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From PRR perspective it seems ok - I added two comments for tests.

I would also encourage you to fill in the scalability section of PRR now, but I'm not going to block on it.

keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md
persisted Pod object, otherwise it is silently dropped; moreover, kube-scheduler
will ignore the field and continue to behave as before.

### Test Plan
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adopt to the new test plan guidelines:

https://github.com/kubernetes/enhancements/tree/master/keps/NNNN-kep-template#test-plan

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

keps/sig-scheduling/3243-respect-pod-topology-spread-after-rolling-upgrades/README.md
- Feature gate enable/disable tests
- `MatchLabelKeys` in `TopologySpreadConstraint` works as expected
- Benchmark tests:
- Verify no significant performance degradation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In existing benchmarks? Or new ones?

I'm assuming existing don't exercise the newly added feature - are we ok with it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to benchmark this using the exist cases in k8s.io/kubernetes/test/integration/scheduler_perf to verify if there's no significant performance degradation.

@denkensk denkensk force-pushed the respect-pod-topology-spread-after-rolling-upgrades branch from 85c24e3 to ceee6ae Compare June 7, 2022 12:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 7, 2022
@denkensk denkensk force-pushed the respect-pod-topology-spread-after-rolling-upgrades branch from ceee6ae to 1b45339 Compare June 7, 2022 12:20
@denkensk denkensk requested a review from wojtek-t June 7, 2022 12:22
@wojtek-t
Copy link
Member

wojtek-t commented Jun 8, 2022

/lgtm
/approve PRR

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 8, 2022
@ahg-g
Copy link
Member

ahg-g commented Jun 8, 2022

/approve
/lgtm

@ahg-g
Copy link
Member

ahg-g commented Jun 8, 2022

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, denkensk, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@ahg-g
Copy link
Member

ahg-g commented Jun 8, 2022

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 8, 2022
@ahg-g
Copy link
Member

ahg-g commented Jun 8, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 957af70 into kubernetes:master Jun 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jun 8, 2022
@denkensk denkensk deleted the respect-pod-topology-spread-after-rolling-upgrades branch June 9, 2022 03:16
@palnabarun palnabarun mentioned this pull request Jun 12, 2022
Closed
@palnabarun palnabarun mentioned this pull request Jul 26, 2022
Closed
@kerthcet kerthcet mentioned this pull request Aug 22, 2022
Merged
pacoxu added a commit to DaoCloud-OpenSource/docs that referenced this pull request Aug 23, 2022
@pacoxu
add PodTopologySpread: Scheduling KEP: kubernetes/enhancements#3244
cae858f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@kerthcet kerthcet kerthcet left review comments

@alculquicondor alculquicondor Awaiting requested review from alculquicondor

@Huang-Wei Huang-Wei Awaiting requested review from Huang-Wei

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@wojtek-t wojtek-t

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.25
Development

Successfully merging this pull request may close these issues.
6 participants
@denkensk @alculquicondor @ahg-g @wojtek-t @k8s-ci-robot @kerthcet