Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KEP Template: Add documentation to template about feature gates #3069

Merged
merged 1 commit into from
Feb 5, 2022
Merged

KEP Template: Add documentation to template about feature gates #3069

merged 1 commit into from
Feb 5, 2022

Conversation

ehashman
Copy link
Member

@ehashman ehashman commented Dec 1, 2021

  • One-line PR description: Add links to SIG Arch documentation on feature gates
  • Issue link: N/A

/sig architecture
/assign @johnbelamaric

@k8s-ci-robot k8s-ci-robot added sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2021
@ehashman
Copy link
Member Author

/label tide/merge-strategy-squash

@k8s-ci-robot
Copy link
Contributor

@ehashman: The label(s) /label tide/merge-strategy-squash cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor

In response to this:

/label tide/merge-strategy-squash

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ehashman
Copy link
Member Author

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 14, 2022
@dims
Copy link
Member

dims commented Feb 5, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, ehashman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 5, 2022
@k8s-ci-robot k8s-ci-robot merged commit 50cecf7 into kubernetes:master Feb 5, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Feb 5, 2022
@palnabarun palnabarun mentioned this pull request Jun 12, 2022
Closed
@palnabarun palnabarun mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@dims dims

@johnbelamaric johnbelamaric

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.
5 participants
@ehashman @k8s-ci-robot @dims @sftim @johnbelamaric