Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #2387 from justaugustus/cleanup" #2425

Merged
merged 1 commit into from
Feb 4, 2021
Merged

Revert "Merge pull request #2387 from justaugustus/cleanup" #2425

merged 1 commit into from
Feb 4, 2021

Conversation

justaugustus
Copy link
Member

This reverts commit 18903e5, reversing
changes made to 5d6d935.

/assign @wojtek-t @palnabarun @jeremyrickard
/priority critical-urgent
cc: @kubernetes/enhancements
ref: #2409 (comment)

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/enhancements Issues or PRs related to the Enhancements subproject labels Feb 4, 2021
@k8s-ci-robot k8s-ci-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 4, 2021
@palnabarun
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 4, 2021
@k8s-ci-robot k8s-ci-robot merged commit 3e2c87b into kubernetes:master Feb 4, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Feb 4, 2021
justaugustus added a commit to justaugustus/enhancements that referenced this pull request Feb 4, 2021
@justaugustus
Revert "Merge pull request kubernetes#2425 from justaugustus/refactor…
44dd3d3 
…-revert"

This reverts commit 3e2c87b, reversing
changes made to 0a495c8.
justaugustus added a commit to justaugustus/enhancements that referenced this pull request Feb 7, 2021
@justaugustus
Revert "Merge pull request kubernetes#2425 from justaugustus/refactor…
5f6a6a6 
…-revert"

This reverts commit 3e2c87b, reversing
changes made to 0a495c8.
justaugustus added a commit to justaugustus/enhancements that referenced this pull request Feb 7, 2021
@justaugustus
Revert "Merge pull request kubernetes#2425 from justaugustus/refactor…
94cf51e 
…-revert"

This reverts commit 3e2c87b, reversing
changes made to 0a495c8.
justaugustus added a commit to justaugustus/enhancements that referenced this pull request Feb 8, 2021
@justaugustus
Revert "Merge pull request kubernetes#2425 from justaugustus/refactor…
c2069a0 
…-revert"

This reverts commit 3e2c87b, reversing
changes made to 0a495c8.
justaugustus added a commit to justaugustus/enhancements that referenced this pull request Feb 10, 2021
@justaugustus
Revert "Merge pull request kubernetes#2425 from justaugustus/refactor…
b61f6b1 
…-revert"

This reverts commit 3e2c87b, reversing
changes made to 0a495c8.
justaugustus added a commit to justaugustus/enhancements that referenced this pull request Feb 10, 2021
@justaugustus
Revert "Merge pull request kubernetes#2425 from justaugustus/refactor…
212a652 
…-revert"

This reverts commit 3e2c87b, reversing
changes made to 0a495c8.
justaugustus added a commit to justaugustus/enhancements that referenced this pull request Feb 10, 2021
@justaugustus
Revert "Merge pull request kubernetes#2425 from justaugustus/refactor…
8a5c584 
…-revert"

This reverts commit 3e2c87b, reversing
changes made to 0a495c8.
@palnabarun palnabarun mentioned this pull request Jun 12, 2022
Closed
@palnabarun palnabarun mentioned this pull request Jul 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

Assignees

@palnabarun palnabarun

@wojtek-t wojtek-t

@jeremyrickard jeremyrickard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/enhancements Issues or PRs related to the Enhancements subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.
5 participants
@justaugustus @k8s-ci-robot @palnabarun @wojtek-t @jeremyrickard